Use an editable combobox for the Cloud Run region field (DT-4232)#3636
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
rossnelson
marked this pull request as ready for review
July 7, 2026 20:06
rossnelson
enabled auto-merge (squash)
July 7, 2026 20:07
| showChevron | ||
| required | ||
| /> | ||
| {#if !errors.gcpRegion?.[0]} |
Contributor
There was a problem hiding this comment.
We should probably make hintText part of Combobox so it can associate the hint text with with the form field via aria-desbribedby. right now the hint text is not associated for accessibility tech users.
tegan-temporal
approved these changes
Jul 13, 2026
rossedfort
added a commit
that referenced
this pull request
Jul 13, 2026
Auto-generated version bump from 2.52.0 to 2.52.1 Bump type: patch Changes included: - [`3be0df00`](3be0df0) fix(schedules): default absent second/minute/hour to 0 when editing (#3653) - [`508b65b7`](508b65b) fix(schedules): default emptied second/minute/hour to 0 on submit (#3655) - [`1f0e149c`](1f0e149) fix(workers): reject $LATEST qualifier in Lambda ARN validation (#3657) - [`b42b0776`](b42b077) a11y(2.4.3): inert-based focus containment + restore; drop trap from native dialogs (#3598) - [`cc491a29`](cc491a2) a11y(2.4.3): keep toast live region announcing during a focus trap [DT-4252] (#3654) - [`ddc7f8e2`](ddc7f8e) a11y(2.4.11): add scroll-padding so sticky overlays don't obscure focused elements (#3532) - [`b7e3a472`](b7e3a47) FilterBar icon update (#3660) - [`09318ec6`](09318ec) Add danger PR comment for api version bump (#3662) - [`273cc4be`](273cc4b) a11y(4.1.2): add label prop to Button primitive and enforce accessible names (#3556) - [`4507115f`](4507115) Use an editable combobox for the Cloud Run region field (DT-4232) (#3636) - [`694a7471`](694a747) a11y(1.4.13): migrate saved-query nav tooltips to Tooltip primitive (#3607) - [`8b384a40`](8b384a4) a11y(4.1.2): fix nested interactive elements in Copyable component (#3558) - [`1bfd2750`](1bfd275) fix describe SANO API requests to include runId parameter (#3661) - [`ba18b43e`](ba18b43) a11y(4.1.2): require label on CodeBlock primitive; add aria-readonly for read-only mode (#3557) - [`6e2290f1`](6e2290f) feat(deployments): make compute provider picker configurable (#3659) - [`4470b76a`](4470b76) fix(workers): persist WDV compute-config edits via update mask; revert $LATEST validation (#3658) - [`17fd591b`](17fd591) fix(nexus-operations): make start standalone nexus operation timeouts optional (#3656) Co-authored-by: rossedfort <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the free-text
gcpRegioninput on the Create Worker Deployment form (Cloud Run provider) with an editable HoloceneCombobox, and makes the suggestion list configurable.GCP_REGIONSlist.allowCustomValue, so an unsupported-by-us region never blocks deployment creation.gcp-region-hintis preserved below the field.gcpRegions?: string[]prop, threaded page -> form ->compute-fields, so cloud-ui can pass its own region list. When omitted, the built-inGCP_REGIONSdefault applies.Combobox fix
While wiring this up, found a latent bug in the shared Holocene
Combobox:addCustomValueunconditionally cleared the input (displayValue = '') after selecting. For single-select this blanked the field even though the value was stored, so a newly added custom value looked unselected. That clear is only meant for multiselect (reset the input for the next chip), so it is now guarded withif (multiselect). The only otherallowCustomValueconsumer (nexus-form) is multiselect, so this path was never exercised before.Why
The worker's region is always a GCP (Cloud Run) region, while the Namespace region may be AWS or Azure, so defaulting to the Namespace region is not reliable. Our
GetRegionslist only covers regions we support for hosting a namespace, not all GCP regions a Cloud Run worker pool can use. This offers helpful suggestions without limiting the user.Notes
gcpRegionstays a required non-empty string, which allows custom values.Testing
pnpm checkpasses (0 errors)pnpm lintpasses (0 errors)Jira: DT-4232