a11y(3.3.1): Holocene input primitives — add aria-invalid, aria-describedby, and uniform live-region error announcement by rosanusi · Pull Request #3554 · temporalio/ui

rosanusi · 2026-06-12T13:54:07Z

Summary

Adds uniform error-association to all seven Holocene input primitives (Input, Textarea, NumberInput, ChipInput, Combobox, Select, Checkbox).

Each primitive now:

Sets aria-invalid="true" on the underlying control when an error is active
Generates a unique errorId (${id}-error) per instance and sets aria-describedby pointing at the error element (only when an error is present — no dangling references)
Renders the error text element with id={errorId} and role="alert" for consistent live-region announcement

This ensures screen-reader users hear the error text both on first render (live region) and when focus returns to an invalid field (via aria-describedby association).

Before: AT reads only the field label when focus returns to an invalid field; user cannot detect the error state programmatically.
After: AT announces field label + "invalid entry, [error text]" via aria-invalid + aria-describedby.

Files changed

src/lib/holocene/input/input.svelte
src/lib/holocene/textarea.svelte
src/lib/holocene/input/number-input.svelte
src/lib/holocene/input/chip-input.svelte
src/lib/holocene/combobox/combobox.svelte
src/lib/holocene/select/select.svelte
src/lib/holocene/checkbox.svelte

Test plan

Inspect DOM for each primitive in an erroring state: confirm aria-invalid="true" on the control, id="{id}-error" on the error element, aria-describedby="{id}-error" on the control, and role="alert" on the error element
Verify no aria-describedby is set when no error is present (no dangling references)
With VoiceOver/NVDA: confirm error is announced on first render and re-announced when focus returns to the invalid field
Regression: error text continues to render visually in the same position; non-error hintText still displays correctly when error=false/valid=true
axe-core: zero new violations on a representative form page

References

WCAG 2.2 SC 3.3.1 Error Identification (Level A)
Cross-walks: SC 1.3.1 Info and Relationships, SC 4.1.2 Name, Role, Value
A11y-Audit-Ref: 3.3.1-holocene-input-primitives-error-association

🤖 Generated with Claude Code

A11y-Audit-Ref: 3.3.1-holocene-input-primitives-error-association

…l seven Holocene input primitives Adds uniform error-association across Input, Textarea, NumberInput, ChipInput, Combobox, Select, and Checkbox so screen-reader users hear the error text when focus returns to an invalid field. Each primitive now: - Sets aria-invalid="true" on the underlying control when an error is active - Generates a unique errorId from the consumer-supplied id prop and sets aria-describedby pointing at the error element (only when an error is present) - Renders the error text element with id={errorId} and role="alert" for consistent live-region announcement across all seven primitives A11y-Audit-Ref: 3.3.1-holocene-input-primitives-error-association Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

vercel · 2026-06-12T13:54:13Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
holocene	Ready	Preview, Comment	Jun 19, 2026 4:13pm

temporal-cicd · 2026-06-12T13:55:26Z

@@ -123,6 +123,9 @@
    // After all the Options are mounted use context to read the label assocaited with the value


⚠️ Argument of type 'T | undefined' is not assignable to parameter of type 'T'.

temporal-cicd · 2026-06-12T13:55:27Z

	Warnings
⚠️	📊 Strict Mode: 23 errors in 7 files (2.6% of 897 total) src/lib/holocene/combobox/combobox.svelte (10) L154:4: Type 'null' is not assignable to type 'string'. L157:4: Type 'null' is not assignable to type '"search" \| "link" \| "success" \| "error" \| "action" \| "activity" \| "add-square" \| "add" \| "apple" \| "archives" \| "arrow-down" \| "arrow-left" \| "arrow-up" \| "arrow-right" \| "ascending" \| ... 141 more ... \| "xmark-square"'. L159:4: Type 'null' is not assignable to type 'keyof T'. L244:4: 'inputElement' is possibly 'null'. L245:4: 'inputElement' is possibly 'null'. L251:14: Argument of type 'string \| T \| undefined' is not assignable to parameter of type 'string \| T'. L256:14: Argument of type 'string \| T \| undefined' is not assignable to parameter of type 'string \| T'. L300:60: Function lacks ending return statement and return type does not include 'undefined'. L393:10: Type 'HTMLLIElement \| null' is not assignable to type 'HTMLLIElement'. L393:43: 'menuElement' is possibly 'null'. src/lib/holocene/input/input.svelte (2) L48:4: Type 'null' is not assignable to type '"search" \| "link" \| "success" \| "error" \| "action" \| "activity" \| "add-square" \| "add" \| "apple" \| "archives" \| "arrow-down" \| "arrow-left" \| "arrow-up" \| "arrow-right" \| "ascending" \| ... 141 more ... \| "xmark-square"'. L104:27: Type 'boolean \| null' is not assignable to type 'boolean \| undefined'. src/lib/holocene/textarea.svelte (1) L29:13: Type 'null' is not assignable to type 'boolean'. src/lib/holocene/checkbox.svelte (3) L33:13: Type 'undefined' is not assignable to type 'T'. L34:13: Type 'undefined' is not assignable to type 'T[]'. L13:12: Argument of type '$$Props' is not assignable to parameter of type '{ id?: string \| undefined; checked?: boolean \| undefined; label?: string \| undefined; labelHidden?: boolean \| undefined; indeterminate?: boolean \| undefined; disabled?: boolean \| undefined; ... 5 more ...; class?: string \| undefined; }'. src/lib/holocene/select/select.svelte (3) L71:4: Type 'null' is not assignable to type '"search" \| "link" \| "success" \| "error" \| "action" \| "activity" \| "add-square" \| "add" \| "apple" \| "archives" \| "arrow-down" \| "arrow-left" \| "arrow-up" \| "arrow-right" \| "ascending" \| ... 141 more ... \| "xmark-square"'. L91:30: Argument of type 'T \| undefined' is not assignable to parameter of type 'T'. L123:36: Argument of type 'T \| undefined' is not assignable to parameter of type 'T'. src/lib/holocene/input/number-input.svelte (3) L9:13: Type 'null' is not assignable to type '"search" \| "link" \| "success" \| "error" \| "action" \| "activity" \| "add-square" \| "add" \| "apple" \| "archives" \| "arrow-down" \| "arrow-left" \| "arrow-up" \| "arrow-right" \| "ascending" \| ... 141 more ... \| "xmark-square"'. L20:13: Type 'undefined' is not assignable to type 'number'. L21:13: Type 'undefined' is not assignable to type 'number'. src/lib/holocene/input/chip-input.svelte (1) L74:30: 'e.clipboardData' is possibly 'null'.

Generated by 🚫 dangerJS against a9d9284

ardiewen · 2026-06-19T17:12:05Z

Added a follow-up ticket: DT-4184 to unify the error/valid contract across the 7 primitives affected here.

Auto-generated version bump from 2.51.1 to 2.52.0 Bump type: minor Changes included: - [`9c6fcd54`](9c6fcd5) Add direct SSO redirect and backend logout (#3590) - [`feab0d90`](feab0d9) a11y(4.1.3): Toaster role="log" → per-toast role="status"/"alert" for correct AT announcement semantics (#3560) - [`d7bbfb01`](d7bbfb0) a11y(2.5.8): toast — replace bare close button with IconButton (36×36 px) (#3553) - [`4efd6ab6`](4efd6ab) a11y(3.3.1): Holocene input primitives — add aria-invalid, aria-describedby, and uniform live-region error announcement (#3554) - [`0600b700`](0600b70) Use green only (#3599) - [`94107549`](9410754) Clarify activity pause timeout behavior (#3600) - [`9f88d5a8`](9f88d5a) Bump node version to 22.23.1 or newer to fix issue from previous security release (#3604) - [`ca4104ae`](ca4104a) Update reason copy and inputs (#3588) - [`51db73fa`](51db73f) Update batch operation reason input hint (#3605) - [`836d7c55`](836d7c5) a11y(2.4.3): route navigation — move focus to the main landmark on afterNavigate, not just scroll (#3538) - [`4ee95696`](4ee9569) Improve re-renders for large encoded event histories (#3592) - [`fa5e7aa1`](fa5e7aa) feature/schedules (#3603) - [`0d9467fd`](0d9467f) Default includeHeartbeatDetails and includeLastFailure to true for getActivityExecution and pollActivityExecution (#3521) - [`e5bc514e`](e5bc514) fix schedules: duplicate key (#3612) - [`f1eb489f`](f1eb489) Remove preview badge (#3581) - [`1e5173b4`](1e5173b) Add existing versions to worker create deployment version form (#3601) - [`a8552bae`](a8552ba) fix schedules -e.trim not a function (#3613) - [`0442f847`](0442f84) Fix width of ComputeBadge in VersionTableRow (#3615) - [`ddbeb54f`](ddbeb54) fix(cloud-nav): animate and stabilize side-nav collapse (#3606) - [`3cfc684b`](3cfc684) fix - schedules recent/upcoming runs - sort issue (#3616) - [`92b8875b`](92b8875) Move timestamp out of translate (#3617) - [`901258af`](901258a) Fix SAA and WF consistency (#3614) - [`99593d97`](99593d9) DT-4001 - standalone nexus operations (#3496) - [`f10d1bf1`](f10d1bf) Clamp codeblock to container width (#3621) - [`0a9d93ce`](0a9d93c) Remove unnecessary bottom-0 (#3623) - [`9dabb522`](9dabb52) chore(deps-dev): bump vite from 6.4.2 to 6.4.3 (#3610) - [`5c1854d3`](5c1854d) News Feed (#3596)

Auto-generated version bump from 2.51.1 to 2.52.0 Bump type: minor Changes included: - [`9c6fcd54`](9c6fcd5) Add direct SSO redirect and backend logout (#3590) - [`feab0d90`](feab0d9) a11y(4.1.3): Toaster role="log" → per-toast role="status"/"alert" for correct AT announcement semantics (#3560) - [`d7bbfb01`](d7bbfb0) a11y(2.5.8): toast — replace bare close button with IconButton (36×36 px) (#3553) - [`4efd6ab6`](4efd6ab) a11y(3.3.1): Holocene input primitives — add aria-invalid, aria-describedby, and uniform live-region error announcement (#3554) - [`0600b700`](0600b70) Use green only (#3599) - [`94107549`](9410754) Clarify activity pause timeout behavior (#3600) - [`9f88d5a8`](9f88d5a) Bump node version to 22.23.1 or newer to fix issue from previous security release (#3604) - [`ca4104ae`](ca4104a) Update reason copy and inputs (#3588) - [`51db73fa`](51db73f) Update batch operation reason input hint (#3605) - [`836d7c55`](836d7c5) a11y(2.4.3): route navigation — move focus to the main landmark on afterNavigate, not just scroll (#3538) - [`4ee95696`](4ee9569) Improve re-renders for large encoded event histories (#3592) - [`fa5e7aa1`](fa5e7aa) feature/schedules (#3603) - [`0d9467fd`](0d9467f) Default includeHeartbeatDetails and includeLastFailure to true for getActivityExecution and pollActivityExecution (#3521) - [`e5bc514e`](e5bc514) fix schedules: duplicate key (#3612) - [`f1eb489f`](f1eb489) Remove preview badge (#3581) - [`1e5173b4`](1e5173b) Add existing versions to worker create deployment version form (#3601) - [`a8552bae`](a8552ba) fix schedules -e.trim not a function (#3613) - [`0442f847`](0442f84) Fix width of ComputeBadge in VersionTableRow (#3615) - [`ddbeb54f`](ddbeb54) fix(cloud-nav): animate and stabilize side-nav collapse (#3606) - [`3cfc684b`](3cfc684) fix - schedules recent/upcoming runs - sort issue (#3616) - [`92b8875b`](92b8875) Move timestamp out of translate (#3617) - [`901258af`](901258a) Fix SAA and WF consistency (#3614) - [`99593d97`](99593d9) DT-4001 - standalone nexus operations (#3496) - [`f10d1bf1`](f10d1bf) Clamp codeblock to container width (#3621) - [`0a9d93ce`](0a9d93c) Remove unnecessary bottom-0 (#3623) - [`9dabb522`](9dabb52) chore(deps-dev): bump vite from 6.4.2 to 6.4.3 (#3610) - [`5c1854d3`](5c1854d) News Feed (#3596) - [`340da30f`](340da30) a11y(2.1.1): guard global r/R keydown so text inputs can receive the letter (#3589) - [`dd97a9d1`](dd97a9d) fix(markdown-editor): disable chromatic snapshot for preview story (#3631) - [`7db61ab9`](7db61ab) a11y(4.1.2): Table / ProgressBar / Loading primitives — expose aria-busy on data-refresh regions (#3555) - [`d2111ecf`](d2111ec) a11y(4.1.3): Add live-region wrappers for workflow status, event count, filter counts, and Banner (#3561) - [`24eabaec`](24eabae) a11y(2.4.6): guard DrawerContent against empty <h2> when title is omitted (#3595) - [`3552e307`](3552e30) Fix CodeMirror Lezer dependency mismatch (#3632) - [`7ac37199`](7ac3719) Update defaults to match workflow defaults (#3634) - [`c1f02865`](c1f0286) Draft fix for link variant handling (#3620) - [`bbbf2b8c`](bbbf2b8) Add connection status and optional Latest Version column to deployments (DT-4174) (#3618) - [`76f266f4`](76f266f) DurationInput updates (#3633) - [`07da53c5`](07da53c) COM-191 - prefill CloudFormation template params in Launch Stack link (#3619) - [`90946e0b`](90946e0) Schedules - Timeout empty defaults (#3637) - [`97f9ad39`](97f9ad3) fix(cloud-nav): smooth label fade on side-nav collapse/expand (#3628) - [`a399ed35`](a399ed3) Improve Search Attribute deletion messaging (#3629) - [`ad976d94`](ad976d9) Pass through source prop for News Feed Widget (#3638) - [`6ef84fe3`](6ef84fe) Restrict select-all to exclude workflow status (#3639) - [`4c3729f8`](4c3729f) Reduce news feed markdown whitespace (#3642) - [`aa04a9b6`](aa04a9b) feat(nexus-operations): add loading state to standalone nexus operations list page header (#3643) - [`dce2f804`](dce2f80) chore: remove unused generate-holocene-props script (#3644) - [`760bc7bc`](760bc7b) Make megaphone icon bigger (#3645) - [`c047384a`](c047384) refactor(nexus): replace hand-rolled types with @temporalio/proto (#3646)

Auto-generated version bump from 2.51.1 to 2.52.0 Bump type: minor Changes included: - [`9c6fcd54`](9c6fcd5) Add direct SSO redirect and backend logout (#3590) - [`feab0d90`](feab0d9) a11y(4.1.3): Toaster role="log" → per-toast role="status"/"alert" for correct AT announcement semantics (#3560) - [`d7bbfb01`](d7bbfb0) a11y(2.5.8): toast — replace bare close button with IconButton (36×36 px) (#3553) - [`4efd6ab6`](4efd6ab) a11y(3.3.1): Holocene input primitives — add aria-invalid, aria-describedby, and uniform live-region error announcement (#3554) - [`0600b700`](0600b70) Use green only (#3599) - [`94107549`](9410754) Clarify activity pause timeout behavior (#3600) - [`9f88d5a8`](9f88d5a) Bump node version to 22.23.1 or newer to fix issue from previous security release (#3604) - [`ca4104ae`](ca4104a) Update reason copy and inputs (#3588) - [`51db73fa`](51db73f) Update batch operation reason input hint (#3605) - [`836d7c55`](836d7c5) a11y(2.4.3): route navigation — move focus to the main landmark on afterNavigate, not just scroll (#3538) - [`4ee95696`](4ee9569) Improve re-renders for large encoded event histories (#3592) - [`fa5e7aa1`](fa5e7aa) feature/schedules (#3603) - [`0d9467fd`](0d9467f) Default includeHeartbeatDetails and includeLastFailure to true for getActivityExecution and pollActivityExecution (#3521) - [`e5bc514e`](e5bc514) fix schedules: duplicate key (#3612) - [`f1eb489f`](f1eb489) Remove preview badge (#3581) - [`1e5173b4`](1e5173b) Add existing versions to worker create deployment version form (#3601) - [`a8552bae`](a8552ba) fix schedules -e.trim not a function (#3613) - [`0442f847`](0442f84) Fix width of ComputeBadge in VersionTableRow (#3615) - [`ddbeb54f`](ddbeb54) fix(cloud-nav): animate and stabilize side-nav collapse (#3606) - [`3cfc684b`](3cfc684) fix - schedules recent/upcoming runs - sort issue (#3616) - [`92b8875b`](92b8875) Move timestamp out of translate (#3617) - [`901258af`](901258a) Fix SAA and WF consistency (#3614) - [`99593d97`](99593d9) DT-4001 - standalone nexus operations (#3496) - [`f10d1bf1`](f10d1bf) Clamp codeblock to container width (#3621) - [`0a9d93ce`](0a9d93c) Remove unnecessary bottom-0 (#3623) - [`9dabb522`](9dabb52) chore(deps-dev): bump vite from 6.4.2 to 6.4.3 (#3610) - [`5c1854d3`](5c1854d) News Feed (#3596) - [`340da30f`](340da30) a11y(2.1.1): guard global r/R keydown so text inputs can receive the letter (#3589) - [`dd97a9d1`](dd97a9d) fix(markdown-editor): disable chromatic snapshot for preview story (#3631) - [`7db61ab9`](7db61ab) a11y(4.1.2): Table / ProgressBar / Loading primitives — expose aria-busy on data-refresh regions (#3555) - [`d2111ecf`](d2111ec) a11y(4.1.3): Add live-region wrappers for workflow status, event count, filter counts, and Banner (#3561) - [`24eabaec`](24eabae) a11y(2.4.6): guard DrawerContent against empty <h2> when title is omitted (#3595) - [`3552e307`](3552e30) Fix CodeMirror Lezer dependency mismatch (#3632) - [`7ac37199`](7ac3719) Update defaults to match workflow defaults (#3634) - [`c1f02865`](c1f0286) Draft fix for link variant handling (#3620) - [`bbbf2b8c`](bbbf2b8) Add connection status and optional Latest Version column to deployments (DT-4174) (#3618) - [`76f266f4`](76f266f) DurationInput updates (#3633) - [`07da53c5`](07da53c) COM-191 - prefill CloudFormation template params in Launch Stack link (#3619) - [`90946e0b`](90946e0) Schedules - Timeout empty defaults (#3637) - [`97f9ad39`](97f9ad3) fix(cloud-nav): smooth label fade on side-nav collapse/expand (#3628) - [`a399ed35`](a399ed3) Improve Search Attribute deletion messaging (#3629) - [`ad976d94`](ad976d9) Pass through source prop for News Feed Widget (#3638) - [`6ef84fe3`](6ef84fe) Restrict select-all to exclude workflow status (#3639) - [`4c3729f8`](4c3729f) Reduce news feed markdown whitespace (#3642) - [`aa04a9b6`](aa04a9b) feat(nexus-operations): add loading state to standalone nexus operations list page header (#3643) - [`dce2f804`](dce2f80) chore: remove unused generate-holocene-props script (#3644) - [`760bc7bc`](760bc7b) Make megaphone icon bigger (#3645) - [`c047384a`](c047384) refactor(nexus): replace hand-rolled types with @temporalio/proto (#3646) Co-authored-by: rossedfort <[email protected]>

github-actions Bot added a11y Accessibility audit PR a11y:no-fix-doc No A11y-Audit-Ref line; audit team triage labels Jun 12, 2026

vercel Bot deployed to Preview June 12, 2026 13:54 View deployment

temporal-cicd Bot reviewed Jun 12, 2026

View reviewed changes

rosanusi marked this pull request as ready for review June 12, 2026 14:20

rosanusi requested a review from a team as a code owner June 12, 2026 14:20

github-actions Bot added a11y:bucket-3 Bucket 3: engineer required a11y:sc-3.3.1 and removed a11y:no-fix-doc No A11y-Audit-Ref line; audit team triage labels Jun 16, 2026

ardiewen added 4 commits June 19, 2026 10:44

fix: prevent duplicate checkbox errorIds

9fb6492

fix: walk back broadened error text role on input primitive

0ce27c6

fix: remove redundant aria-live="assertive" when role is "alert"

2240c2d

fix: disabled elements are out of the a11y tree

3f37b94

vercel Bot deployed to Preview June 19, 2026 15:03 View deployment

fix: always-rendered live regions, conditional content

f09cf44

vercel Bot deployed to Preview June 19, 2026 15:36 View deployment

fix: unify error patterns on primitives

a9d9284

vercel Bot deployed to Preview June 19, 2026 16:13 View deployment

ardiewen approved these changes Jun 19, 2026

View reviewed changes

ardiewen merged commit 4efd6ab into main Jun 24, 2026
18 checks passed

ardiewen deleted the wcag/3.3.1-input-primitives-error-association branch June 24, 2026 18:06

temporal-cicd Bot mentioned this pull request Jul 2, 2026

chore: bump version to 2.52.0 #3626

Closed

temporal-cicd Bot mentioned this pull request Jul 8, 2026

chore: bump version to 2.52.0 #3647

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

a11y(3.3.1): Holocene input primitives — add aria-invalid, aria-describedby, and uniform live-region error announcement#3554

a11y(3.3.1): Holocene input primitives — add aria-invalid, aria-describedby, and uniform live-region error announcement#3554
ardiewen merged 7 commits into
mainfrom
wcag/3.3.1-input-primitives-error-association

rosanusi commented Jun 12, 2026 •

edited by ardiewen

Loading

Uh oh!

vercel Bot commented Jun 12, 2026 •

edited

Loading

Uh oh!

temporal-cicd Bot Jun 12, 2026

Uh oh!

temporal-cicd Bot commented Jun 12, 2026 •

edited

Loading

Uh oh!

ardiewen commented Jun 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -123,6 +123,9 @@
		// After all the Options are mounted use context to read the label assocaited with the value

Uh oh!

Conversation

rosanusi commented Jun 12, 2026 • edited by ardiewen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Files changed

Test plan

References

Uh oh!

vercel Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

temporal-cicd Bot Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

temporal-cicd Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ardiewen commented Jun 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rosanusi commented Jun 12, 2026 •

edited by ardiewen

Loading

vercel Bot commented Jun 12, 2026 •

edited

Loading

temporal-cicd Bot commented Jun 12, 2026 •

edited

Loading