Schedules redesign 5/5: view page, list, and action modals#3552
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tegan-temporal
force-pushed
the
tegan/schedules-pr5-view
branch
from
June 11, 2026 18:27
7e0c7aa to
889107d
Compare
laurakwhit
reviewed
Jun 16, 2026
laurakwhit
left a comment
laurakwhit
left a comment
Collaborator
There was a problem hiding this comment.
Looking good! Noticed a few small things, but no major blockers.
tegan-temporal
force-pushed
the
tegan/schedules-pr5-view
branch
from
June 18, 2026 19:30
43355f6 to
6574eb8
Compare
The payload input now validates JSON for json/plain encoding, so submit a JSON string, and the schedule heading contains the status badge, so match on containment. Co-Authored-By: Claude Fable 5 <[email protected]>
Co-authored-by: Laura Whitaker <[email protected]>
tegan-temporal
force-pushed
the
tegan/schedules-pr5-view
branch
from
June 18, 2026 23:07
788be8a to
5cb2736
Compare
laurakwhit
approved these changes
Jun 19, 2026
laurakwhit
left a comment
laurakwhit
left a comment
Collaborator
There was a problem hiding this comment.
Few super small comments, but otherwise 
| > | ||
| <Icon | ||
| name="filter" | ||
| title="Filter scheduled workflows by this type" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Final PR of the stack. After this merges,
feature/schedulesis byte-identical totegan/schedules-update(verified with an emptygit diff).schedule-view/card-based page: spec card with full-spec toggle, advanced settings, recent/upcoming workflow runs, workflow input, custom search attributesschedule-action-modals/: trigger, backfill, and pause modals rendered through a conditionally-mounted host keyed on the confirmation-modal store, so every open starts with fresh state (no stale selections, reasons, or page-load timestamps). Trigger pre-selects Allow All (matching server behavior for manual triggers) and both overlap pickers mark the schedule's current policyschedules-list/schedule-spec-label, legacy schedule types (ScheduleParametersfamily,Unspecifiedoverlap policy), and legacy i18n keysTesting 🧪
How was this tested 👻
pnpm check0 errors,pnpm lint0 errors, 2,080 unit tests passing, full integration suite 233 passed / 0 failed. Newschedule-actions.spec.tscovers trigger patch bodies, backfill request + post-success modal usability, modal state reset on reopen, timezone caption, end-before-start validation, and delete. The e2e spec now does a full create → verify summary → delete loop but needs a run against a real Temporal server (not runnable locally).Steps for others to test: 🚶🏽♂️🚶🏽♀️
On a schedule view page: trigger, backfill (try an end time before the start time, and reopen modals to confirm state resets), pause/unpause with a reason, and delete.
Checklists
Merge Checklist
feature/schedulestomainfeature/schedules(notmain)🤖 Generated with Claude Code