Schedules redesign 1/5: Holocene and shared component updates#3548
Merged
Conversation
Additive component changes split out of the schedules feature work: new ButtonRadioGroup, new code icon, optional props across inputs and pickers (DatePicker id/clearable, TimePicker idPrefix/error, Checkbox description, NumberInput error, Panel as, PayloadInput placeholder/ copyable), Svelte 5 conversion of RadioGroup, DurationInput rework, and styling refinements. No deletions and no behavior changes for existing consumers. Co-Authored-By: Claude Fable 5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jun 11, 2026
tegan-temporal
requested review from
Alex-Tideman,
KATIETOLER,
laurakwhit and
rossnelson
June 11, 2026 18:39
Comment on lines
12
to
17
| export let twelveHourClock = true; | ||
| export let includeSeconds = true; | ||
| export let disabled = false; | ||
| export let error = false; | ||
| export let idPrefix = ''; | ||
|
|
Collaborator
There was a problem hiding this comment.
Might be a good excuse to convert to Svelte5 now
Alex-Tideman
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
First of five PRs splitting the schedules redesign (
tegan/schedules-update) into reviewable pieces, all targetingfeature/schedules.This PR contains only the Holocene design-system and shared-component changes the redesign depends on. Everything is additive — new optional props and new components, no deletions, no behavior changes for existing consumers.
ButtonRadioGroupcomponent (+ Storybook stories) and newcodeiconRadioGroupconverted to Svelte 5 runes (wire-compatible: no consumer changes needed)DatePicker: optionalidandclearable/requiredprops (fixes duplicateid="datepicker"when two pickers share a page)TimePicker:idPrefixanderrorprops; minute/second inputs now validate their own values (previously checked the hour)DurationInputrework: simpler empty-value handling, blur passthrough,error/hintTextAbove/inputClasspropsCheckboxdescription,NumberInputerror,IconButtonsize,InputsnippethintText,Panelas,PayloadInputplaceholder/copyable,Buttonfocus()exportDesign Considerations 🎨
ButtonRadioGroupcoexists withToggleButtonsintentionally — it carries radio-group semantics for mutually exclusive choices.Testing 🧪
How was this tested 👻
Full gates on this branch:
pnpm check0 errors,pnpm lint0 errors, 2,035 unit tests passing, full integration suite 207 passed / 0 failed (exercises the existing pages against the updated components).Steps for others to test: 🚶🏽♂️🚶🏽♀️
Existing pages should look and behave the same; the new props are unused until the later PRs in this stack.
Checklists
Merge Checklist
feature/schedules(notmain)🤖 Generated with Claude Code