Skip to content

a11y(2.4.5): import history — add back-link to Import landing page#3542

Merged
ardiewen merged 1 commit into
mainfrom
wcag/2.4.5-detail-page-back-links
Jun 16, 2026
Merged

a11y(2.4.5): import history — add back-link to Import landing page#3542
ardiewen merged 1 commit into
mainfrom
wcag/2.4.5-detail-page-back-links

Conversation

@rosanusi

Copy link
Copy Markdown
Contributor

Description

WCAG 2.4.5 (Multiple Ways, Level AA) requires every non-process page to be reachable through at least two navigation mechanisms. The import event-history sub-routes (/import/events/[namespace]/[workflow]/[run]/history/{compact,json,feed}) were reachable only via the side-nav + list click — no back-link provided a one-step return path.

This PR adds a "Back to Import" <Link icon="chevron-left"> at the layout level (history/+layout.svelte), so it appears on all three view tabs in one place. The new events.back-to-import i18n key is added alongside the existing import-related keys.

The two other defects cited in the audit issue (Nexus detail, Archival history) were already addressed in main prior to this PR.

Changed files:

  • src/routes/(app)/import/events/[namespace]/[workflow]/[run]/history/+layout.svelte — add back-link above <ImportEventsView>
  • src/lib/i18n/locales/en/events.ts — add 'back-to-import': 'Back to Import'

Screenshots

N/A — text link matching the existing chevron-left back-link pattern used across 15+ other detail pages.

Design

Follows the established pattern from src/lib/pages/worker-details.svelte, src/lib/layouts/workflow-header.svelte, and src/lib/components/schedule/schedule-form/form.svelte.

Testing

  • Navigate to /import/events, upload a history JSON, and open any of the three view tabs (compact / json / feed).
  • Confirm a "Back to Import" link appears above the view, styled identically to other back-links (chevron-left icon).
  • Click the link — confirm navigation to /import/events.
  • Keyboard: Tab to the link, press Enter — same navigation.
  • Switching between the three view tabs preserves the back-link on every tab.
  • axe-core: zero new violations on the history routes.

Checklist

  • Tests added / updated (n/a — UI-only addition, covered by manual test plan above)
  • i18n key added (events.back-to-import)
  • Storybook story added / updated (n/a — layout addition, no isolated story needed)

Docs

No documentation changes required.

A11y-Audit-Ref: 2.4.5-ui-main-detail-page-back-links

Adds the missing second navigation mechanism (WCAG 2.4.5) to the
import event-history sub-routes. The layout now renders a "Back to
Import" chevron-left link above the history view, covering all three
tab views (compact, json, feed) in one place.

The Nexus detail and Archival history pages already carry back-links
in main; only the import history layout was missing.

A11y-Audit-Ref: 2.4.5-ui-main-detail-page-back-links

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Jun 11, 2026 5:04pm

Request Review

@github-actions github-actions Bot added a11y Accessibility audit PR a11y:bucket-2 Bucket 2: design-mergeable, HTML / ARIA a11y:sc-2.4.5 labels Jun 11, 2026
@rosanusi
rosanusi marked this pull request as ready for review June 11, 2026 17:20
@rosanusi
rosanusi requested a review from a team as a code owner June 11, 2026 17:20
@ardiewen
ardiewen merged commit 9da915e into main Jun 16, 2026
20 checks passed
@ardiewen
ardiewen deleted the wcag/2.4.5-detail-page-back-links branch June 16, 2026 19:45
laurakwhit added a commit that referenced this pull request Jun 23, 2026
Auto-generated version bump from 2.51.0 to 2.51.1

Specific version: 2.51.1

Changes included:
- [`c848ec54`](c848ec5) fix(a11y): announce workflow / event status on timeline graph nodes (WCAG 1.4.1) (#3443)
- [`af6b12a9`](af6b12a) fix(deployments): align version/status/compute badges in worker deployments table (#3489)
- [`df86587c`](df86587) Add SDK version to standalone activity details (#3447)
- [`59695290`](5969529) Use shared FilterBar component for workflows (#3448)
- [`ded94469`](ded9446) Set display contents in wrapper div if no afterLabel in Input component (#3513)
- [`d7e5eb43`](d7e5eb4) fix(standalone-activities): decode failure encodedAttributes in activity detail (#3507)
- [`81a255a9`](81a255a) fix(DT-4151): fix bottom nav scrollability and double-menu on mobile (#3514)
- [`368f646e`](368f646) Fix exports to work properly with vite8 (#3519)
- [`231bdaff`](231bdaf) chore(deps-dev): bump vitest from 3.2.4 to 3.2.6 (#3509)
- [`1de44ea6`](1de44ea) fix(workers): soften no-workers-polling alert for serverless worker deployments (#3524)
- [`689955a8`](689955a) fix(DT-4080): surface error when validate connection has no compute config, warn on set current (#3516)
- [`93323db9`](93323db) feat(DT-4078): Add Set Ramping Version to Worker Deployment Versions (#3508)
- [`9d3450c0`](9d3450c) fix(DT-4081): surface task queue not registered error in validate connection modal (#3517)
- [`b7f56237`](b7f5623) feat(DT-4079): miscellaneous WD UI fixes (#3511)
- [`83b2d4ec`](83b2d4e) feat(deployments): simplify create worker deployment UX (#3518)
- [`ccb4cb73`](ccb4cb7) Standalone Activity write guards (#3534)
- [`ab20ef03`](ab20ef0) Worker insights UI updates (#3520)
- [`aaf63bdc`](aaf63bd) [wcag] Replace text-[12px] with text-xs in DatePicker action buttons (SC 1.4.4) (#3525)
- [`743be902`](743be90) a11y(2.4.3): replace flex-wrap-reverse with flex-wrap on workflow history toolbar (#3527)
- [`41b73e87`](41b73e8) a11y(2.4.2): ui-main — set distinct, descriptive titles on login/signin, task-queues list, and activity-workers sub-tab (#3535)
- [`3d64cdbf`](3d64cdb) [WCAG 2.4.3] group-details-row — remove redundant outer focus stop on <g> wrapper (#3537)
- [`883e5db1`](883e5db) a11y(2.4.6): datepicker — replace empty label with translate('common.start') (#3543)
- [`9da915e2`](9da915e) a11y(2.4.5): import history — add back-link to Import landing page (#3542)
- [`ca4c1d61`](ca4c1d6) Cache new Intl.DateTimeFormat (#3565)
- [`38376e4d`](38376e4) Fix required activity timeout inputs on Start a Standalone Activity form (#3567)
- [`49d7c9e4`](49d7c9e) Use separate copy for title vs menu item (#3568)
- [`3c7dcdc3`](3c7dcdc) a11y(2.5.8): pagination — grow caret buttons from 12×12 to 24×24 CSS px (#3547)
- [`b5171825`](b517182) a11y(2.5.8): chip — pad remove button to 24×24 CSS px minimum (#3544)
- [`1fea5d5c`](1fea5d5) a11y(2.1.1): fake-button widgets — replace deprecated onkeypress with onkeydown handling Enter and Space (#3528)
- [`5bf09000`](5bf0900) a11y(2.1.1): navigation primitives — replace hover-only CSS :after label tooltip with focusable Tooltip (#3529)
- [`deed43f0`](deed43f) a11y(2.1.1): event summary row — add keyboard-accessible expand control alongside the mouse-only <tr onclick> (#3526)
- [`d401123e`](d401123) a11y(2.5.8): checkbox — add min-h-6 min-w-6 to Label for 24×24 hit area (#3545)
- [`aef4166f`](aef4166) [a11y] Expose toggled state via aria-pressed on ToggleButton (#3559)
- [`797f8831`](797f883) Show single attempt in Standalone Activity details (#3572)
- [`893bc58c`](893bc58) feat(DT-4183): Add Tabs (Primitive) (#3574)
- [`323c1993`](323c199) Date picker input field bug/kt (#3522)
- [`3ac34ce2`](3ac34ce) Various serverless UI updates (#3573)
- [`f365416a`](f365416) a11y(2.1.1): ZoomSvg — add keyboard pan/zoom controls so the workflow family tree is operable without a mouse (#3530)
- [`feb6897e`](feb6897) Fix gaps in slot cards on worker details page (#3580)
- [`b3c80072`](b3c8007) Remove font weight on cache size (#3583)
- [`0e7337ea`](0e7337e) Bump API to v1.62.14 (#3575)

Co-authored-by: laurakwhit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y:bucket-2 Bucket 2: design-mergeable, HTML / ARIA a11y:sc-2.4.5 a11y Accessibility audit PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants