Skip to content

a11y(1.4.4): date-picker — replace pixel-locked text-[12px] with rem-based text-xs#3525

Merged
ardiewen merged 1 commit into
mainfrom
wcag/1.4.4-date-picker-text-xs
Jun 16, 2026
Merged

a11y(1.4.4): date-picker — replace pixel-locked text-[12px] with rem-based text-xs#3525
ardiewen merged 1 commit into
mainfrom
wcag/1.4.4-date-picker-text-xs

Conversation

@rosanusi

@rosanusi rosanusi commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes WCAG 2.2 SC 1.4.4 (Resize Text) in src/lib/holocene/date-picker.svelte.

The "Today" and "Close" buttons inside the DatePicker popover used text-[12px] — a pixel-locked font size that bypasses browser text-size preferences and Firefox text-only zoom. Under those settings the buttons stay fixed at 12 px while surrounding text scales, breaking the 200% resize requirement.

Replacing with text-xs emits font-size: 0.75rem — visually identical at the browser default (16 px root = 12 px rendered), but scales correctly with user preferences.

Screenshots

No visual change at default zoom. Difference is only observable under Firefox text-only zoom or a non-default root font size.

Design

No design change. 0.75rem equals 12px at the browser default; the intent of the original value is preserved.

Testing

  • Open any page with a DatePicker (workflow filter date range, schedule create form, usage chart date picker) and open the calendar popover.
  • Inspect the "Today" and "Close" buttons in DevTools — confirm font-size: 0.75rem (not 12px).
  • Firefox → View → Zoom → Zoom Text Only → Cmd+= to 200% — confirm both buttons scale proportionally with the calendar grid.
  • At default zoom: confirm the visual is identical to before.

Checklist

Docs

No documentation changes required.

A11y-Audit-Ref: 1.4.4-date-picker-text-size

…(SC 1.4.4)

Pixel-locked font-size bypasses Firefox text-only zoom and browser default
font-size preferences. text-xs emits 0.75rem — identical rendering at the
default root font size but scales with user preferences.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Jun 10, 2026 8:43pm

Request Review

@CLAassistant

CLAassistant commented Jun 10, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@rosanusi rosanusi changed the title [wcag] SC 1.4.4 — Replace text-[12px] with text-xs in DatePicker action buttons a11y(1.4.4): date-picker — replace pixel-locked text-[12px] with rem-based text-xs Jun 11, 2026
@github-actions github-actions Bot added a11y Accessibility audit PR a11y:bucket-1 Bucket 1: design-mergeable, CSS / tokens a11y:sc-1.4.4 labels Jun 11, 2026
@rosanusi
rosanusi marked this pull request as ready for review June 11, 2026 14:45
@rosanusi
rosanusi requested a review from a team as a code owner June 11, 2026 14:45
@ardiewen
ardiewen merged commit aaf63bd into main Jun 16, 2026
23 checks passed
@ardiewen
ardiewen deleted the wcag/1.4.4-date-picker-text-xs branch June 16, 2026 18:52
laurakwhit added a commit that referenced this pull request Jun 23, 2026
Auto-generated version bump from 2.51.0 to 2.51.1

Specific version: 2.51.1

Changes included:
- [`c848ec54`](c848ec5) fix(a11y): announce workflow / event status on timeline graph nodes (WCAG 1.4.1) (#3443)
- [`af6b12a9`](af6b12a) fix(deployments): align version/status/compute badges in worker deployments table (#3489)
- [`df86587c`](df86587) Add SDK version to standalone activity details (#3447)
- [`59695290`](5969529) Use shared FilterBar component for workflows (#3448)
- [`ded94469`](ded9446) Set display contents in wrapper div if no afterLabel in Input component (#3513)
- [`d7e5eb43`](d7e5eb4) fix(standalone-activities): decode failure encodedAttributes in activity detail (#3507)
- [`81a255a9`](81a255a) fix(DT-4151): fix bottom nav scrollability and double-menu on mobile (#3514)
- [`368f646e`](368f646) Fix exports to work properly with vite8 (#3519)
- [`231bdaff`](231bdaf) chore(deps-dev): bump vitest from 3.2.4 to 3.2.6 (#3509)
- [`1de44ea6`](1de44ea) fix(workers): soften no-workers-polling alert for serverless worker deployments (#3524)
- [`689955a8`](689955a) fix(DT-4080): surface error when validate connection has no compute config, warn on set current (#3516)
- [`93323db9`](93323db) feat(DT-4078): Add Set Ramping Version to Worker Deployment Versions (#3508)
- [`9d3450c0`](9d3450c) fix(DT-4081): surface task queue not registered error in validate connection modal (#3517)
- [`b7f56237`](b7f5623) feat(DT-4079): miscellaneous WD UI fixes (#3511)
- [`83b2d4ec`](83b2d4e) feat(deployments): simplify create worker deployment UX (#3518)
- [`ccb4cb73`](ccb4cb7) Standalone Activity write guards (#3534)
- [`ab20ef03`](ab20ef0) Worker insights UI updates (#3520)
- [`aaf63bdc`](aaf63bd) [wcag] Replace text-[12px] with text-xs in DatePicker action buttons (SC 1.4.4) (#3525)
- [`743be902`](743be90) a11y(2.4.3): replace flex-wrap-reverse with flex-wrap on workflow history toolbar (#3527)
- [`41b73e87`](41b73e8) a11y(2.4.2): ui-main — set distinct, descriptive titles on login/signin, task-queues list, and activity-workers sub-tab (#3535)
- [`3d64cdbf`](3d64cdb) [WCAG 2.4.3] group-details-row — remove redundant outer focus stop on <g> wrapper (#3537)
- [`883e5db1`](883e5db) a11y(2.4.6): datepicker — replace empty label with translate('common.start') (#3543)
- [`9da915e2`](9da915e) a11y(2.4.5): import history — add back-link to Import landing page (#3542)
- [`ca4c1d61`](ca4c1d6) Cache new Intl.DateTimeFormat (#3565)
- [`38376e4d`](38376e4) Fix required activity timeout inputs on Start a Standalone Activity form (#3567)
- [`49d7c9e4`](49d7c9e) Use separate copy for title vs menu item (#3568)
- [`3c7dcdc3`](3c7dcdc) a11y(2.5.8): pagination — grow caret buttons from 12×12 to 24×24 CSS px (#3547)
- [`b5171825`](b517182) a11y(2.5.8): chip — pad remove button to 24×24 CSS px minimum (#3544)
- [`1fea5d5c`](1fea5d5) a11y(2.1.1): fake-button widgets — replace deprecated onkeypress with onkeydown handling Enter and Space (#3528)
- [`5bf09000`](5bf0900) a11y(2.1.1): navigation primitives — replace hover-only CSS :after label tooltip with focusable Tooltip (#3529)
- [`deed43f0`](deed43f) a11y(2.1.1): event summary row — add keyboard-accessible expand control alongside the mouse-only <tr onclick> (#3526)
- [`d401123e`](d401123) a11y(2.5.8): checkbox — add min-h-6 min-w-6 to Label for 24×24 hit area (#3545)
- [`aef4166f`](aef4166) [a11y] Expose toggled state via aria-pressed on ToggleButton (#3559)
- [`797f8831`](797f883) Show single attempt in Standalone Activity details (#3572)
- [`893bc58c`](893bc58) feat(DT-4183): Add Tabs (Primitive) (#3574)
- [`323c1993`](323c199) Date picker input field bug/kt (#3522)
- [`3ac34ce2`](3ac34ce) Various serverless UI updates (#3573)
- [`f365416a`](f365416) a11y(2.1.1): ZoomSvg — add keyboard pan/zoom controls so the workflow family tree is operable without a mouse (#3530)
- [`feb6897e`](feb6897) Fix gaps in slot cards on worker details page (#3580)
- [`b3c80072`](b3c8007) Remove font weight on cache size (#3583)
- [`0e7337ea`](0e7337e) Bump API to v1.62.14 (#3575)

Co-authored-by: laurakwhit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y:bucket-1 Bucket 1: design-mergeable, CSS / tokens a11y:sc-1.4.4 a11y Accessibility audit PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants