Skip to content

Fix tsgo union too complex error#3381

Merged
tegan-temporal merged 1 commit into
ts-upgradefrom
fix-merge-event-group-details-union-too-complex
May 6, 2026
Merged

Fix tsgo union too complex error#3381
tegan-temporal merged 1 commit into
ts-upgradefrom
fix-merge-event-group-details-union-too-complex

Conversation

@tegan-temporal

Copy link
Copy Markdown
Contributor

Description & motivation 💭

Reapply #3378

it got lost in a rebase

@tegan-temporal tegan-temporal self-assigned this May 6, 2026
@tegan-temporal
tegan-temporal requested a review from a team as a code owner May 6, 2026 20:47
@vercel

vercel Bot commented May 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment May 6, 2026 8:47pm

Request Review

@tegan-temporal
tegan-temporal merged commit f5eabff into ts-upgrade May 6, 2026
6 checks passed
@tegan-temporal
tegan-temporal deleted the fix-merge-event-group-details-union-too-complex branch May 6, 2026 20:58
rossnelson added a commit that referenced this pull request May 7, 2026
* chore: upgrade TypeScript to v6.0.3

- Bump typescript from ^5.2.2 to 6.0.3
- Add explicit `strict: false` to tsconfig to preserve existing behavior
  (TS 6 now defaults strict to true)
- Fix two event handler type errors caused by TS 6 DOM lib typing
  on:input as InputEvent instead of Event

* chore: add @typescript/native-preview for tsgo support

Enables `svelte-check --tsgo` and `svelte-check --tsgo --incremental`
for faster type checking using the Go-based TypeScript compiler.

* chore: enable --tsgo --incremental for svelte-check

Faster type checking via Go-based TS compiler with disk-cached
svelte2tsx transpilation. Will report errors in 4 unmigrated Svelte 4
components until they are converted to Svelte 5 runes.

* ts-upgrade: Migrate chip-input to fix tsgo error (#3380)

* Fix tsgo union too complex error (#3381)

* fix: replace redundant comma operator reactive statements

$: (dep, fn()) is unnecessary when fn() already reads dep internally.
Replaced with $: fn() which Svelte tracks as a dependency automatically.

* fix: preserve reactive dependencies using block instead of comma operator

Replaces $: (dep, fn()) with $: { dep; fn(); } to keep the explicit
dependency declaration while avoiding the tsgo comma operator error.

---------

Co-authored-by: Tegan Churchill <[email protected]>
ardiewen pushed a commit that referenced this pull request May 11, 2026
* chore: upgrade TypeScript to v6.0.3

- Bump typescript from ^5.2.2 to 6.0.3
- Add explicit `strict: false` to tsconfig to preserve existing behavior
  (TS 6 now defaults strict to true)
- Fix two event handler type errors caused by TS 6 DOM lib typing
  on:input as InputEvent instead of Event

* chore: add @typescript/native-preview for tsgo support

Enables `svelte-check --tsgo` and `svelte-check --tsgo --incremental`
for faster type checking using the Go-based TypeScript compiler.

* chore: enable --tsgo --incremental for svelte-check

Faster type checking via Go-based TS compiler with disk-cached
svelte2tsx transpilation. Will report errors in 4 unmigrated Svelte 4
components until they are converted to Svelte 5 runes.

* ts-upgrade: Migrate chip-input to fix tsgo error (#3380)

* Fix tsgo union too complex error (#3381)

* fix: replace redundant comma operator reactive statements

$: (dep, fn()) is unnecessary when fn() already reads dep internally.
Replaced with $: fn() which Svelte tracks as a dependency automatically.

* fix: preserve reactive dependencies using block instead of comma operator

Replaces $: (dep, fn()) with $: { dep; fn(); } to keep the explicit
dependency declaration while avoiding the tsgo comma operator error.

---------

Co-authored-by: Tegan Churchill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants