Skip to content

feat: add showInstancesLink prop to deployment header#3331

Merged
rossnelson merged 1 commit into
mainfrom
hide-instances-link-flag
Apr 22, 2026
Merged

feat: add showInstancesLink prop to deployment header#3331
rossnelson merged 1 commit into
mainfrom
hide-instances-link-flag

Conversation

@rossnelson

Copy link
Copy Markdown
Collaborator

Summary

  • Adds optional showInstancesLink prop (default true) to DeploymentHeader
  • Threads the prop through deployment.svelte so callers can hide the "Go to Instances" link
  • Needed by cloud-ui to gate the link behind the enable_worker_insights feature flag per this review comment

Test plan

  • Verify "Go to Instances" still shows by default (no prop change needed for OSS deployments)
  • Verify cloud-ui can pass showInstancesLink={false} to hide the link when enable_worker_insights is disabled

Allows callers to conditionally hide the "Go to Instances" link, needed
for cloud-ui to gate it behind the enable_worker_insights feature flag.
@rossnelson
rossnelson requested a review from a team as a code owner April 21, 2026 19:42
@vercel

vercel Bot commented Apr 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Apr 21, 2026 7:43pm

Request Review

@rossnelson
rossnelson merged commit 627cbb1 into main Apr 22, 2026
19 checks passed
@rossnelson
rossnelson deleted the hide-instances-link-flag branch April 22, 2026 14:08
rossedfort added a commit that referenced this pull request Apr 22, 2026
Auto-generated version bump from 2.48.4 to 2.49.0

Bump type: minor

Changes included:
- [`9146199f`](9146199) fix: ref main in reusable PR review workflows (#3326)
- [`ca904926`](ca90492) test(e2e): add end-to-end payload decoder coverage (#3321)
- [`4e32d230`](4e32d23) chore: add setup-worktree skill (#3278)
- [`a789fbdb`](a789fbd) Fix decoding payloads for user metadata (#3328)
- [`21f2d448`](21f2d44) ci: remove unused Set up Protoc step from workflows (#3323)
- [`39c41d25`](39c41d2) fix(ui): guard getApiOrigin against undefined VITE_API (#3332)
- [`627cbb1b`](627cbb1) feat: add showInstancesLink prop to deployment header (#3331)
- [`0726c65e`](0726c65) Check certFile modification time instead of keyFile (#3178)
- [`8c79931b`](8c79931) feat(DT-3887): remove Dispatch Rate Epsilon from compute scaling UI (#3334)

Co-authored-by: rossedfort <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants