Skip to content

Make input height full so its easier to focus input#3318

Merged
Alex-Tideman merged 1 commit into
mainfrom
input-height
Apr 16, 2026
Merged

Make input height full so its easier to focus input#3318
Alex-Tideman merged 1 commit into
mainfrom
input-height

Conversation

@Alex-Tideman

@Alex-Tideman Alex-Tideman commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator

Description & motivation 💭

Because the input wasn't full height of it's parent container, there was a decent amount of vertical gap when trying to click into the input. By making the input full height, the full vertical area of the input is clickable to focus.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@Alex-Tideman
Alex-Tideman requested a review from a team as a code owner April 16, 2026 18:01
@vercel

vercel Bot commented Apr 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Apr 16, 2026 6:01pm

Request Review

@temporal-cicd

temporal-cicd Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

📊 Strict Mode: 3 errors in 1 file (0.3% of 1049 total)

src/lib/holocene/input/input.svelte (3)
  • L50:13: Type 'null' is not assignable to type '"action" | "activity" | "add-square" | "add" | "apple" | "archives" | "arrow-down" | "arrow-left" | "arrow-up" | "arrow-right" | "ascending" | "astronaut" | "batch-operation" | ... 137 more ... | "xmark-square"'.
  • L63:13: Type 'null' is not assignable to type 'boolean'.
  • L44:7: Argument of type '$$Props' is not assignable to parameter of type '{ id: string; value: string; label: string; labelHidden?: boolean | undefined; icon?: "action" | "activity" | "add-square" | "add" | "apple" | "archives" | "arrow-down" | "arrow-left" | ... 143 more ... | undefined; ... 20 more ...; inputContainerClass?: string | undefined; }'.

Generated by 🚫 dangerJS against 3523a87

@Alex-Tideman
Alex-Tideman merged commit 04f8c25 into main Apr 16, 2026
17 checks passed
@Alex-Tideman
Alex-Tideman deleted the input-height branch April 16, 2026 18:11
rossnelson added a commit that referenced this pull request Apr 20, 2026
Auto-generated version bump from 2.48.3 to 2.48.4

Specific version: 2.48.4

Changes included:
- [`7cf1be53`](7cf1be5) Adjust breadcrumb spacing and min-height (#3304)
- [`c9834815`](c983481) Add missing Nexus Operation events to event groups (#3309)
- [`5c7aa86c`](5c7aa86) feat: add onItemsChange callback to PaginatedTable (#3300)
- [`66d3cf68`](66d3cf6) Update pre-release badge to secondary in Workers (#3310)
- [`393e84de`](393e84d) Keep Pending Activities/Operations at the top of Timeline and Compact view (#3307)
- [`9f721347`](9f72134) Update error link in codec-server-error-banner (#3313)
- [`e698bda3`](e698bda) Add class prop to BottomNav component (#3314)
- [`55767fc9`](55767fc) Add overrides (#3317)
- [`256cd274`](256cd27) refactor(decode-payload): clean up decode-payload.ts API surface (#3302)
- [`04f8c251`](04f8c25) Make input height full so its easier to click into the input (#3318)
- [`b2231056`](b223105) Workflows Table Row Density (#3285)
- [`0b2ce4fd`](0b2ce4f) PR Review Notifications (#3322)
- [`84618196`](8461819) feat: serverless worker deployment CRUD (#3236)

Co-authored-by: rossnelson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants