Add missing Nexus Operation events to event groups#3309
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| return String(event.nexusOperationCanceledEventAttributes.scheduledEventId); | ||
| } | ||
|
|
||
| if (isNexusOperationTimedOutEvent(event)) { |
Contributor
There was a problem hiding this comment.
⚠️ 'event.nexusOperationTimedOutEventAttributes' is possibly 'null' or 'undefined'.
| } | ||
|
|
||
| if (isNexusOperationCancelRequestedEvent(event)) { | ||
| return String( |
Contributor
There was a problem hiding this comment.
⚠️ 'event.nexusOperationCancelRequestedEventAttributes' is possibly 'null' or 'undefined'.
| } | ||
|
|
||
| if (isNexusOperationCancelRequestCompletedEvent(event)) { | ||
| return String( |
Contributor
There was a problem hiding this comment.
⚠️ 'event.nexusOperationCancelRequestCompletedEventAttributes' is possibly 'null' or 'undefined'.
| } | ||
|
|
||
| if (isNexusOperationCancelRequestFailedEvent(event)) { | ||
| return String( |
Contributor
There was a problem hiding this comment.
⚠️ 'event.nexusOperationCancelRequestFailedEventAttributes' is possibly 'null' or 'undefined'.
Contributor
|
rossedfort
approved these changes
Apr 15, 2026
rossnelson
added a commit
that referenced
this pull request
Apr 20, 2026
Auto-generated version bump from 2.48.3 to 2.48.4 Specific version: 2.48.4 Changes included: - [`7cf1be53`](7cf1be5) Adjust breadcrumb spacing and min-height (#3304) - [`c9834815`](c983481) Add missing Nexus Operation events to event groups (#3309) - [`5c7aa86c`](5c7aa86) feat: add onItemsChange callback to PaginatedTable (#3300) - [`66d3cf68`](66d3cf6) Update pre-release badge to secondary in Workers (#3310) - [`393e84de`](393e84d) Keep Pending Activities/Operations at the top of Timeline and Compact view (#3307) - [`9f721347`](9f72134) Update error link in codec-server-error-banner (#3313) - [`e698bda3`](e698bda) Add class prop to BottomNav component (#3314) - [`55767fc9`](55767fc) Add overrides (#3317) - [`256cd274`](256cd27) refactor(decode-payload): clean up decode-payload.ts API surface (#3302) - [`04f8c251`](04f8c25) Make input height full so its easier to click into the input (#3318) - [`b2231056`](b223105) Workflows Table Row Density (#3285) - [`0b2ce4fd`](0b2ce4f) PR Review Notifications (#3322) - [`84618196`](8461819) feat: serverless worker deployment CRUD (#3236) Co-authored-by: rossnelson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
We were missing the NexusOperationTimedOut and all NexusOperationCancelRequest events in our event group building. This fixes that.
Screenshots (if applicable) 📸
Before
After
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?