Skip to content

Keep Pending Activities/Operations at the top of Timeline and Compact view#3307

Merged
Alex-Tideman merged 3 commits into
mainfrom
pending-activities-on-top
Apr 15, 2026
Merged

Keep Pending Activities/Operations at the top of Timeline and Compact view#3307
Alex-Tideman merged 3 commits into
mainfrom
pending-activities-on-top

Conversation

@Alex-Tideman

@Alex-Tideman Alex-Tideman commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Make it easier for our users to find pending activities and operations without needing to scroll to find them.

Description & motivation 💭

Summary

  • Pending activities and nexus operations now consistently appear at the top of Compact and Timeline views (descending) or bottom (ascending), matching the existing All view behavior
  • Compact view pending groups display "Pending Activity" / "Pending Nexus Operation" as the event type with a pulsing icon, matching the All view presentation
  • Fixed a bug in the timeline's activeGroupsHeightAboveGroup that used numeric ID comparison to determine row ordering — replaced with index-based comparison that works correctly regardless of group reordering

Test plan

  • Open a workflow with pending activities in descending order
  • Verify All view shows pending activities at the top (existing behavior, unchanged)
  • Switch to Compact view — pending groups should appear at the top with "Pending Activity" label and pulsing icon
  • Switch to Timeline view — pending groups should appear as the topmost rows
  • Toggle to ascending sort — pending groups should move to the bottom in all three views
  • Verify expanding a group row in Timeline view does not overlap adjacent rows
  • Test with the failed/pending status filter enabled in Timeline view
  • Verify workflows with no pending activities render normally in all views
  • Unit tests pass: pnpm test -- --run src/lib/utilities/order-groups-by-pending.test.ts

Screenshots (if applicable) 📸

Screenshot 2026-04-14 at 2 08 30 PM Screenshot 2026-04-14 at 2 12 30 PM Screenshot 2026-04-14 at 3 07 38 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@Alex-Tideman
Alex-Tideman requested a review from a team as a code owner April 14, 2026 19:30
@temporal-cicd

temporal-cicd Bot commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
Warnings
⚠️

📊 Strict Mode: 18 errors in 5 files (1.7% of 1063 total)

src/lib/components/event/event-summary-row.svelte (5)
  • L134:6: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
  • L171:23: Parameter 'event' implicitly has an 'any' type.
  • L183:30: Parameter 'group' implicitly has an 'any' type.
  • L183:37: Parameter 'hoveredEventId' implicitly has an 'any' type.
  • L317:16: Type 'ITimestamp | null | undefined' is not assignable to type 'ITimestamp'.
src/lib/components/event/event-summary.svelte (3)
  • L28:7: Object is possibly 'null'.
  • L33:25: 'workflow' is possibly 'null'.
  • L34:30: 'workflow' is possibly 'null'.
src/lib/components/lines-and-dots/svg/timeline-graph.svelte (3)
  • L35:4: Object is possibly 'null' or 'undefined'.
  • L44:24: Parameter 'e' implicitly has an 'any' type.
  • L104:9: Type 'number | null' is not assignable to type 'number'.
src/lib/layouts/workflow-history-layout.svelte (3)
  • L198:10: Type 'boolean | null' is not assignable to type 'boolean | undefined'.
  • L239:2: Type 'string | undefined' is not assignable to type 'string'.
  • L240:2: Type 'string | undefined' is not assignable to type 'string'.
src/lib/layouts/workflow-timeline-layout.svelte (4)
  • L120:10: Type 'boolean | null' is not assignable to type 'boolean | undefined'.
  • L148:7: Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
  • L158:14: 'workflow' is possibly 'null'.
  • L159:9: 'workflow' is possibly 'null'.

Generated by 🚫 dangerJS against c84f06e

@Alex-Tideman Alex-Tideman changed the title Keep pending activities at the top of Timeline and Compact view Keep Pending Activities/Operations at the top of Timeline and Compact view Apr 14, 2026
@vercel

vercel Bot commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Apr 15, 2026 4:23pm

Request Review

laurakwhit
laurakwhit reviewed Apr 15, 2026
View reviewed changes
Comment thread src/lib/components/event/event-summary-row.svelte Outdated
Comment thread src/lib/components/lines-and-dots/svg/timeline-graph.svelte Outdated
Comment thread src/lib/utilities/order-groups-by-pending.ts Outdated
@Alex-Tideman
Alex-Tideman merged commit 393e84d into main Apr 15, 2026
17 checks passed
@Alex-Tideman
Alex-Tideman deleted the pending-activities-on-top branch April 15, 2026 20:57
@temporal-cicd temporal-cicd Bot mentioned this pull request Apr 20, 2026
Merged
rossnelson added a commit that referenced this pull request Apr 20, 2026
@temporal-cicd @rossnelson
chore: bump version to 2.48.4 (#3324)
86feca3 
Auto-generated version bump from 2.48.3 to 2.48.4

Specific version: 2.48.4

Changes included:
- [`7cf1be53`](7cf1be5) Adjust breadcrumb spacing and min-height (#3304)
- [`c9834815`](c983481) Add missing Nexus Operation events to event groups (#3309)
- [`5c7aa86c`](5c7aa86) feat: add onItemsChange callback to PaginatedTable (#3300)
- [`66d3cf68`](66d3cf6) Update pre-release badge to secondary in Workers (#3310)
- [`393e84de`](393e84d) Keep Pending Activities/Operations at the top of Timeline and Compact view (#3307)
- [`9f721347`](9f72134) Update error link in codec-server-error-banner (#3313)
- [`e698bda3`](e698bda) Add class prop to BottomNav component (#3314)
- [`55767fc9`](55767fc) Add overrides (#3317)
- [`256cd274`](256cd27) refactor(decode-payload): clean up decode-payload.ts API surface (#3302)
- [`04f8c251`](04f8c25) Make input height full so its easier to click into the input (#3318)
- [`b2231056`](b223105) Workflows Table Row Density (#3285)
- [`0b2ce4fd`](0b2ce4f) PR Review Notifications (#3322)
- [`84618196`](8461819) feat: serverless worker deployment CRUD (#3236)

Co-authored-by: rossnelson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurakwhit laurakwhit laurakwhit approved these changes
@rossnelson rossnelson Awaiting requested review from rossnelson
@andrewzamojc andrewzamojc Awaiting requested review from andrewzamojc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alex-Tideman @laurakwhit