Add invite icon to Holocene design system#3262
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
andrewzamojc
marked this pull request as ready for review
March 31, 2026 20:48
andrewzamojc
enabled auto-merge (squash)
March 31, 2026 20:55
Contributor
Author
|
Is 17 minutes normal for the e2e testing in this repo? |
|
LGTM |
auto-merge was automatically disabled
March 31, 2026 21:16
Pull request was closed
Contributor
Author
|
ALFRED! HOW COULD YOU! lol |
andrewzamojc
enabled auto-merge (squash)
March 31, 2026 21:40
Alex-Tideman
self-requested a review
March 31, 2026 21:45
Alex-Tideman
approved these changes
Mar 31, 2026
Alex-Tideman
added a commit
that referenced
this pull request
Apr 1, 2026
…3262) Create a reusable common-error component system for displaying operational guidance about workflow misconfigurations. Includes typed data for 35 known issues with severity levels, documentation links, and a /common-errors route.
temporal-cicd Bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
Auto-generated version bump from 2.48.1 to 2.48.2 Specific version: 2.48.2 Changes included: - [`92cd681e`](92cd681) Re-wire auth to use a provider pattern. Lots of tests remove cloud references (#3230) - [`3d92202b`](3d92202) Use --top-nav-height CSS variable for sticky element positioning (#3250) - [`16295986`](1629598) Bump saved view limits from 20 to 50 (#3254) - [`a9fa0e91`](a9fa0e9) Display cron string instead of calendar spec when schedule has a cron string in comment field (#3241) - [`f1811715`](f181171) use full for 100% instead of 100vh (#3256) - [`0dfadd74`](0dfadd7) Add samples-ruby to workflows table empty state (#3259) - [`d85d61a3`](d85d61a) Display human-readable schedule spec labels (#3261) - [`b63049c5`](b63049c) Add invite icon to Holocene design system (#3262) - [`00c6418c`](00c6418) Bump google.golang.org/grpc from 1.66.1 to 1.79.3 in /server (#3232) - [`b04a3676`](b04a367) Add back animation (#3251) - [`7b651524`](7b65152) Bump github.com/go-jose/go-jose/v4 from 4.1.3 to 4.1.4 in /server (#3268) - [`45f4fdea`](45f4fde) use snippets for nexus CTAs (#3266) - [`420f5c9d`](420f5c9) min-h-full instead of screen (#3270) - [`f5b2fab6`](f5b2fab) feat(navigation): add NavSection Holocene component (#3263) - [`657b2728`](657b272) Adds requested design changes to breadcrumb items (#3267) - [`6763cc4d`](6763cc4) Remove serena (#3273) - [`dfff353e`](dfff353) Display Principal fields in Event History (#3272) - [`2d289bce`](2d289bc) Update CODEOWNERS to wildcard for temporalio/frontend-engineering (#3275) - [`a2eaf16e`](a2eaf16) Persist workflow view and sort order preferences across navigation (#3260) - [`c5d4c996`](c5d4c99) Add link from Event Card to jump to event id page from Timeline. Remove unnecessary padding (#3277) - [`e5b3ea55`](e5b3ea5) fix(deps): upgrade lodash, svelte, kit, storybook, tar-fs for security (#3269) - [`b44afbe6`](b44afbe) fix(deps): upgrade vite and add picomatch/svgo overrides for security (#3279) - [`4e8cb4e9`](4e8cb4e) Fix unpause confirmation modal title (#3280) - [`740b3529`](740b352) Add Slack notification when DESIGN FEEDBACK REQUESTED label is added to a PR (#3282) - [`7e8170e4`](7e8170e) Add check for COLLABORATOR (#3283) - [`dc27109d`](dc27109) fix: update nav item margin from mb-1 to mb-2 (#3290) - [`3e6416d2`](3e6416d) Pass execution runId in workflow request for schedule recent run (#3289) - [`ae3a1844`](ae3a184) Fix schedule edit double-encoding header fields (#3287) - [`09c083e0`](09c083e) fix: prevent reset modal from closing on authorization error (#3291) - [`0aa3b72b`](0aa3b72) Sort namespace picker alphabetically (#3286) - [`4c3d0057`](4c3d005) Sort alphabetically utility (#3293) - [`67a988b9`](67a988b) Bump @sveltejs/kit from 2.55.0 to 2.57.1 (#3294)
laurakwhit
added a commit
that referenced
this pull request
Apr 10, 2026
Auto-generated version bump from 2.48.1 to 2.48.2 Specific version: 2.48.2 Changes included: - [`92cd681e`](92cd681) Re-wire auth to use a provider pattern. Lots of tests remove cloud references (#3230) - [`3d92202b`](3d92202) Use --top-nav-height CSS variable for sticky element positioning (#3250) - [`16295986`](1629598) Bump saved view limits from 20 to 50 (#3254) - [`a9fa0e91`](a9fa0e9) Display cron string instead of calendar spec when schedule has a cron string in comment field (#3241) - [`f1811715`](f181171) use full for 100% instead of 100vh (#3256) - [`0dfadd74`](0dfadd7) Add samples-ruby to workflows table empty state (#3259) - [`d85d61a3`](d85d61a) Display human-readable schedule spec labels (#3261) - [`b63049c5`](b63049c) Add invite icon to Holocene design system (#3262) - [`00c6418c`](00c6418) Bump google.golang.org/grpc from 1.66.1 to 1.79.3 in /server (#3232) - [`b04a3676`](b04a367) Add back animation (#3251) - [`7b651524`](7b65152) Bump github.com/go-jose/go-jose/v4 from 4.1.3 to 4.1.4 in /server (#3268) - [`45f4fdea`](45f4fde) use snippets for nexus CTAs (#3266) - [`420f5c9d`](420f5c9) min-h-full instead of screen (#3270) - [`f5b2fab6`](f5b2fab) feat(navigation): add NavSection Holocene component (#3263) - [`657b2728`](657b272) Adds requested design changes to breadcrumb items (#3267) - [`6763cc4d`](6763cc4) Remove serena (#3273) - [`dfff353e`](dfff353) Display Principal fields in Event History (#3272) - [`2d289bce`](2d289bc) Update CODEOWNERS to wildcard for temporalio/frontend-engineering (#3275) - [`a2eaf16e`](a2eaf16) Persist workflow view and sort order preferences across navigation (#3260) - [`c5d4c996`](c5d4c99) Add link from Event Card to jump to event id page from Timeline. Remove unnecessary padding (#3277) - [`e5b3ea55`](e5b3ea5) fix(deps): upgrade lodash, svelte, kit, storybook, tar-fs for security (#3269) - [`b44afbe6`](b44afbe) fix(deps): upgrade vite and add picomatch/svgo overrides for security (#3279) - [`4e8cb4e9`](4e8cb4e) Fix unpause confirmation modal title (#3280) - [`740b3529`](740b352) Add Slack notification when DESIGN FEEDBACK REQUESTED label is added to a PR (#3282) - [`7e8170e4`](7e8170e) Add check for COLLABORATOR (#3283) - [`dc27109d`](dc27109) fix: update nav item margin from mb-1 to mb-2 (#3290) - [`3e6416d2`](3e6416d) Pass execution runId in workflow request for schedule recent run (#3289) - [`ae3a1844`](ae3a184) Fix schedule edit double-encoding header fields (#3287) - [`09c083e0`](09c083e) fix: prevent reset modal from closing on authorization error (#3291) - [`0aa3b72b`](0aa3b72) Sort namespace picker alphabetically (#3286) - [`4c3d0057`](4c3d005) Sort alphabetically utility (#3293) - [`67a988b9`](67a988b) Bump @sveltejs/kit from 2.55.0 to 2.57.1 (#3294) Co-authored-by: laurakwhit <[email protected]>
Alex-Tideman
added a commit
that referenced
this pull request
Apr 28, 2026
* Add common-error component with 35 workflow configuration warnings (#3262) Create a reusable common-error component system for displaying operational guidance about workflow misconfigurations. Includes typed data for 35 known issues with severity levels, documentation links, and a /common-errors route. * Integrate common-error detection into workflow detail header Add automatic detection of 21 workflow configuration issues and display them as warnings in the workflow header. Detection covers timeout misconfigurations, retry policy issues, heartbeat settings, and more. Also fixes raw code references in error titles. * Fix detection accuracy for common errors - Raise #31 threshold from 4000 to 10000 to match "significant additional events" - Add null guards to all getCommonErrorById calls via addError helper - Detect #3 (short timeout) from workflowRunTimeout on first event, not just execution timeout - Fix #10 false positives for empty retry policy objects - Handle protobuf nanos field in durationToSeconds for sub-second durations * Add detection logic for 14 remaining common errors (#8-#35) Implement Tier 1 detections from existing data (#9, #11, #13, #15, #19, #23, #35) and Tier 2 detections from event history scanning (#8, #12, #26, #27, #28, #29, #30). Adds detectEventHistoryErrors with single-pass scanning and updates getApplicableCommonErrors to accept optional event history. All 35 error definitions now have active detection logic. * Add snippet to pass in headerSnippet for common errors. Refactor workflow-run-layout to svelte5 * Add back common errors page * Remove common errors from snippet * Revert alert to current styles * Fix test failures for detectFirstEventErrors and routeForCommonErrors Update detectFirstEventErrors test calls to match updated function signature that removed the workflow parameter. Add missing routeForCommonErrors test case to route-for-base-path tests. * Replace VerticalNav with tab group on common errors page Switch from VerticalNav sidebar to TabButtons for severity filtering. Remove layout reset (@) since the page no longer needs a custom layout. Add WorkflowCommonErrors snippet to workflow run layout. * Remove common errors from header snippet * Fix type errors in alert component and stories Rename $$Props to Props in alert.svelte for Svelte 5 convention. Update stories to use module script and ComponentProps for proper type inference with Storybook. * Update src/lib/components/common-errors/common-error.svelte Co-authored-by: Laura Whitaker <[email protected]> * Update src/lib/components/common-errors/common-errors-data.ts Co-authored-by: Laura Whitaker <[email protected]> * Update src/lib/utilities/common-error-detection.ts Co-authored-by: Laura Whitaker <[email protected]> * Remove workflow-common-errors.svelte * Remove getCommonErrorsByCategory * Update src/lib/components/common-errors/common-error-list.svelte Co-authored-by: Laura Whitaker <[email protected]> * Fix naming * Add back workflow-common-errors.svelte ;5u * Formatting * Add type predicate filter --------- Co-authored-by: Laura Whitaker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inviteicon (person + plus) to the Holocene icon setsrc/lib/holocene/icon/svg/invite.sveltewith the SVG path datapaths.tsso it's available as<Icon name="invite" />Test plan
Closes DT-3727