Add underline, arrow, and subtitle href structure#3231
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
For the back arrow icon, subtitle link, and the expand/collapse icon, can we update to |
|
I don't know if you want to tackle this as part of this PR, but I just want to make sure the icons are all lined up nicely like this screenshot. You might have to play around with spacing. Happy to a pair session on this. 
|
Hey @bilal-karim I think that this is something we should talk about. We have been struggling with Icon's lately. Sometimes they seem to be not quite square even after doing the whole download format thing. I think that's why the team brought up the Icon's in the last FEUX meeting. I think we might want to find a better system for getting the Icon's right. The formatting should be consistent on the FE side so really if we can get the Icons to all be exact, It should automatically line up perfectly. Any more thoughts on how to get the icons right? We would appreciate any help you can give us on the icons front for sure. It's a pain point for the whole team. My personal thoughts are to get the couple of padding tweaks in and then get this in. We can follow up with getting the icons right, unless there's a way to get that done quickly? |
I'll add a new screenshot with the new icons once I have them in place in Cloud and have linked everything up, then ya'll can judge if they're centered etc. I just wanted to show the dividers initially, next time I'll make a more explicit note about the repo context. |
|
Sounds good, thanks @KATIETOLER and @GraceGardner. Let's talk about icons separately once everything is linked up. |
|
| import verticalEllipsis from './svg/vertical-ellipsis.svelte'; | ||
| import warning from './svg/warning.svelte'; | ||
| import workflow from './svg/workflow.svelte'; | ||
| import workflows from './svg/workflows.svelte'; |
There was a problem hiding this comment.
Is this replacing the workflow icon?
Auto-generated version bump from 2.48.0 to 2.48.1 Bump type: patch Changes included: - [`30614969`](3061496) Add underline, arrow, and subtitle href structure (#3231) - [`75176b6c`](75176b6) remove animation in refresh (#3240) - [`1c2cdc0a`](1c2cdc0) Remove 120 max/min height and make it 300 to be consistent with others (#3242)
Auto-generated version bump from 2.48.0 to 2.48.1 Bump type: patch Changes included: - [`30614969`](3061496) Add underline, arrow, and subtitle href structure (#3231) - [`75176b6c`](75176b6) remove animation in refresh (#3240) - [`1c2cdc0a`](1c2cdc0) Remove 120 max/min height and make it 300 to be consistent with others (#3242) Co-authored-by: Alex-Tideman <[email protected]>
3 participants
New style structure for Contextual Nav
This adds a subtitle that is also a link.
This will allow the subtitles to link back to previous nav contexts.