Skip to content

Comments

[DT-3582] Make Build ID and Deployment Name copyable and filterable#3121

Merged
rossnelson merged 1 commit intomainfrom
DT-3582-copyable-filterable-build-id
Jan 28, 2026
Merged

[DT-3582] Make Build ID and Deployment Name copyable and filterable#3121
rossnelson merged 1 commit intomainfrom
DT-3582-copyable-filterable-build-id

Conversation

@rossnelson
Copy link
Collaborator

Summary

  • Add Copyable wrappers to build IDs and deployment names across deployment views
  • Build IDs now link to filtered workflow list showing workflows for that deployment version
  • Applies to workflow details, deployment table rows, and version table rows

Test plan

  • Verify copy button appears on hover for build IDs and deployment names
  • Click build ID link and verify it filters workflows by TemporalWorkerDeploymentVersion
  • Test on workflow details page, deployments list, and version list

…terable

Add Copyable wrappers and filter links to build IDs and deployment names
across workflow details, deployment table rows, and version table rows.
Filter links use TemporalWorkerDeploymentVersion search attribute.
@vercel
Copy link

vercel bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
holocene Ready Ready Preview, Comment Jan 27, 2026 2:52pm

Request Review

'common.copy-success-icon-title',
)}
>
<Link
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Type 'string | undefined' is not assignable to type 'string'.

'common.copy-success-icon-title',
)}
>
<Link
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Type 'string | undefined' is not assignable to type 'string'.

'common.copy-success-icon-title',
)}
>
<Link
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Type 'string | undefined' is not assignable to type 'string'.

copyIconTitle={translate('common.copy-icon-title')}
copySuccessIconTitle={translate('common.copy-success-icon-title')}
>
<Link
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Type 'string | undefined' is not assignable to type 'string'.

<DetailListLinkValue
copyable
copyableText={versioningBuildId}
text={versioningBuildId}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Type 'string | undefined' is not assignable to type 'string'.

<DetailListLinkValue
copyable
copyableText={versioningBehavior}
text={versioningBehavior}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Type 'string | undefined' is not assignable to type 'string'.

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Jan 27, 2026

Warnings
⚠️

📊 Strict Mode: 18 errors in 3 files (1.6% of 1126 total)

src/lib/components/deployments/deployment-table-row.svelte (4)
  • L77:18: Type 'string | undefined' is not assignable to type 'string'.
  • L101:18: Type 'string | undefined' is not assignable to type 'string'.
  • L130:18: Type 'string | undefined' is not assignable to type 'string'.
  • L177:10: Type 'string | undefined' is not assignable to type 'string'.
src/lib/components/deployments/version-table-row.svelte (5)
  • L47:8: 'version.deploymentVersion' is possibly 'undefined'.
  • L52:8: 'version.deploymentVersion' is possibly 'undefined'.
  • L88:12: Type 'number | undefined' is not assignable to type 'string | number'.
  • L106:12: Type 'string | undefined' is not assignable to type 'string'.
  • L136:10: Type 'string | undefined' is not assignable to type 'string'.
src/lib/components/lines-and-dots/workflow-details.svelte (9)
  • L83:41: 'e.billableActions' is possibly 'undefined'.
  • L165:6: Type 'string | undefined' is not assignable to type 'string'.
  • L174:6: Type 'string | undefined' is not assignable to type 'string'.
  • L177:8: Type 'string | undefined' is not assignable to type 'string'.
  • L215:10: Type 'string | undefined' is not assignable to type 'string'.
  • L233:10: Type 'string | undefined' is not assignable to type 'string'.
  • L258:8: Type 'string | null | undefined' is not assignable to type 'string'.
  • L261:10: Type 'string | null | undefined' is not assignable to type 'string'.
  • L262:10: Type 'string | null | undefined' is not assignable to type 'string'.

Generated by 🚫 dangerJS against 2e113ad

Copy link
Contributor

@rossedfort rossedfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, however I'm pretty sure that <Copyable /> makes the text clickable, how does that interaction work when the text is also a link?

@rossnelson rossnelson merged commit ef6b923 into main Jan 28, 2026
24 checks passed
@rossnelson rossnelson deleted the DT-3582-copyable-filterable-build-id branch January 28, 2026 18:13
temporal-cicd bot pushed a commit that referenced this pull request Feb 4, 2026
Auto-generated version bump from 2.44.1 to 2.45.0

Bump type: minor

Changes included:
- [`4d828b96`](4d828b9) Account for potential not in conditional in custom query (#3081)
- [`bead6b37`](bead6b3) Fix truncate in detail-list-text-value (#3089)
- [`bb4bee6c`](bb4bee6) Bump svelte dependencies (#3097)
- [`586bfe19`](586bfe1) Test section
- [`4ad6cfff`](4ad6cff) Remove sisyphus and add to .gitignore (#3104)
- [`0aea80f3`](0aea80f) Nav update icons clean (#3095)
- [`bca75cc5`](bca75cc) make routes conditional on prop (#3106)
- [`0008100b`](0008100) Add new Nexus timeout fields and translations (#3105)
- [`b9939675`](b993967) Bump golang.org/x/crypto from 0.38.0 to 0.45.0 in /server (#3028)
- [`5963ca9c`](5963ca9) Nav release fix/kt (#3110)
- [`3cab346e`](3cab346) quick nav fix add logo and route to title (#3112)
- [`f9f75d64`](f9f75d6) [DT-3501] reactive timestamp (#3108)
- [`faa48e2b`](faa48e2) [DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover (#3113)
- [`068e5978`](068e597) Fix nav collapse icon (#3117)
- [`d0b34226`](d0b3422) feat(workflows): show Versioning Behavior column when filtering by deployment version (#3120)
- [`bd8a3556`](bd8a355) [DT-3580] Add tooltips to worker deployment version status badges (#3119)
- [`f46dca00`](f46dca0) Add Portal component (#3107)
- [`ef6b923e`](ef6b923) feat(deployments): make build ID and deployment name copyable and filterable (#3121)
- [`6209f9b6`](6209f9b) DT-3507-fix-code-block-scrolling (#3129)
- [`023f034b`](023f034) DT-3523 - standalone activities UI (#3124)
- [`7199ce9e`](7199ce9) Set API to v1.60.0 (#3132)
temporal-cicd bot pushed a commit that referenced this pull request Feb 4, 2026
Auto-generated version bump from 2.44.1 to 2.45.0

Bump type: minor

Changes included:
- [`4d828b96`](4d828b9) Account for potential not in conditional in custom query (#3081)
- [`bead6b37`](bead6b3) Fix truncate in detail-list-text-value (#3089)
- [`bb4bee6c`](bb4bee6) Bump svelte dependencies (#3097)
- [`586bfe19`](586bfe1) Test section
- [`4ad6cfff`](4ad6cff) Remove sisyphus and add to .gitignore (#3104)
- [`0aea80f3`](0aea80f) Nav update icons clean (#3095)
- [`bca75cc5`](bca75cc) make routes conditional on prop (#3106)
- [`0008100b`](0008100) Add new Nexus timeout fields and translations (#3105)
- [`b9939675`](b993967) Bump golang.org/x/crypto from 0.38.0 to 0.45.0 in /server (#3028)
- [`5963ca9c`](5963ca9) Nav release fix/kt (#3110)
- [`3cab346e`](3cab346) quick nav fix add logo and route to title (#3112)
- [`f9f75d64`](f9f75d6) [DT-3501] reactive timestamp (#3108)
- [`faa48e2b`](faa48e2) [DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover (#3113)
- [`068e5978`](068e597) Fix nav collapse icon (#3117)
- [`d0b34226`](d0b3422) feat(workflows): show Versioning Behavior column when filtering by deployment version (#3120)
- [`bd8a3556`](bd8a355) [DT-3580] Add tooltips to worker deployment version status badges (#3119)
- [`f46dca00`](f46dca0) Add Portal component (#3107)
- [`ef6b923e`](ef6b923) feat(deployments): make build ID and deployment name copyable and filterable (#3121)
- [`6209f9b6`](6209f9b) DT-3507-fix-code-block-scrolling (#3129)
- [`023f034b`](023f034) DT-3523 - standalone activities UI (#3124)
- [`7199ce9e`](7199ce9) Set API to v1.60.0 (#3132)
- [`138473c6`](138473c) Set API to v1.60.1 (#3134)
laurakwhit added a commit that referenced this pull request Feb 4, 2026
Auto-generated version bump from 2.44.1 to 2.45.0

Bump type: minor

Changes included:
- [`4d828b96`](4d828b9) Account for potential not in conditional in custom query (#3081)
- [`bead6b37`](bead6b3) Fix truncate in detail-list-text-value (#3089)
- [`bb4bee6c`](bb4bee6) Bump svelte dependencies (#3097)
- [`586bfe19`](586bfe1) Test section
- [`4ad6cfff`](4ad6cff) Remove sisyphus and add to .gitignore (#3104)
- [`0aea80f3`](0aea80f) Nav update icons clean (#3095)
- [`bca75cc5`](bca75cc) make routes conditional on prop (#3106)
- [`0008100b`](0008100) Add new Nexus timeout fields and translations (#3105)
- [`b9939675`](b993967) Bump golang.org/x/crypto from 0.38.0 to 0.45.0 in /server (#3028)
- [`5963ca9c`](5963ca9) Nav release fix/kt (#3110)
- [`3cab346e`](3cab346) quick nav fix add logo and route to title (#3112)
- [`f9f75d64`](f9f75d6) [DT-3501] reactive timestamp (#3108)
- [`faa48e2b`](faa48e2) [DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover (#3113)
- [`068e5978`](068e597) Fix nav collapse icon (#3117)
- [`d0b34226`](d0b3422) feat(workflows): show Versioning Behavior column when filtering by deployment version (#3120)
- [`bd8a3556`](bd8a355) [DT-3580] Add tooltips to worker deployment version status badges (#3119)
- [`f46dca00`](f46dca0) Add Portal component (#3107)
- [`ef6b923e`](ef6b923) feat(deployments): make build ID and deployment name copyable and filterable (#3121)
- [`6209f9b6`](6209f9b) DT-3507-fix-code-block-scrolling (#3129)
- [`023f034b`](023f034) DT-3523 - standalone activities UI (#3124)
- [`7199ce9e`](7199ce9) Set API to v1.60.0 (#3132)
- [`138473c6`](138473c) Set API to v1.60.1 (#3134)

Co-authored-by: laurakwhit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants