Skip to content

Comments

Nav update icons clean#3095

Merged
KATIETOLER merged 14 commits intomainfrom
nav-update-icons-clean
Jan 21, 2026
Merged

Nav update icons clean#3095
KATIETOLER merged 14 commits intomainfrom
nav-update-icons-clean

Conversation

@KATIETOLER
Copy link
Contributor

@KATIETOLER KATIETOLER commented Jan 14, 2026

Nav Container Update

This PR is meant to add the underlying structure for the new nav.


Add new navigation icons

Adds buildings and cube icons to the Holocene icon library for use in
navigation updates.

Changes

  • New icons: Added buildings.svelte and cube.svelte icon components
  • Icon registry: Updated paths.ts to register new icons
  • Cleanup: Removed unused identities-icon.svelte
  • Navigation: Enhanced navigation container to support both Cloud (with
    subtitle/push icon) and Self-Hosted (with chevron icon) layouts
  • Svelte 5 migration: Converted navigation components from slot syntax to
    snippet syntax for compatibility

Technical Notes

  • Maintains backward compatibility for UI/Core
  • Conditional rendering based on isCloud and subtitle props
  • Supports future subtitle functionality for Cloud repo when packaged

KATIETOLER and others added 5 commits January 9, 2026 14:16
- Add buildings.svelte icon for organizations/projects
- Add cube.svelte icon for deployments/packages
- Remove unused identities-icon.svelte
- Update icon registry in paths.ts

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
- Cloud with subtitle: uses push icon and new layout
- Self-Hosted / Cloud without subtitle: uses chevron icon and standard layout
- Maintains backward compatibility for UI/Core
- Supports new subtitle functionality for Cloud repo

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
- Convert from slot syntax to Svelte 5 snippet syntax
- Update Navigation to use children and bottom snippets
- Update SideNavigation to pass snippets instead of slots
- Update layout to use snippet syntax for bottom nav item

Fixes Vite/Svelte compilation error about mixing slot and render tags

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@vercel
Copy link

vercel bot commented Jan 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
holocene Ready Ready Preview, Comment Jan 21, 2026 4:21pm

Request Review

@KATIETOLER KATIETOLER removed the request for review from rossedfort January 14, 2026 23:27
Addresses code review feedback to separate navigation logic into
distinct components instead of using conditional rendering.

- Create CloudNavBar component for Cloud nav with subtitle/push icon
- Create OSSNavBar component for Self-Hosted nav with chevron icon
- Update navigation-container to delegate to appropriate component
- Improves code maintainability and component reusability

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Copy link
Contributor

@andrewzamojc andrewzamojc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I left a couple comments.

{#if item.divider}
<hr class="-mx-4 my-4 border-subtle" />
<Navigation {isCloud} {bottom} aria-label={translate('common.primary')}>
{#snippet children()}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Jan 15, 2026

Warnings
⚠️

📊 Strict Mode: 3 errors in 3 files (0.3% of 1120 total)

src/lib/holocene/menu/menu-container.svelte (1)
  • L36:8: Type 'Writable' is not assignable to type 'Writable'.
src/lib/holocene/navigation/navigation-container.svelte (1)
  • L33:3: Argument of type '{ accesskey?: string | undefined | null; autocapitalize?: "characters" | "off" | "on" | "none" | "sentences" | "words" | undefined | null; autofocus?: boolean | undefined | null; ... 432 more ...; xmlns?: string | undefined | null; }' is not assignable to parameter of type 'HTMLProps<"nav", HTMLAttributes>'.
src/routes/(app)/+layout.svelte (1)
  • L58:23: Argument of type '(namespace: string) => { namespace: string; onClick: (namespace: string) => void; }' is not assignable to parameter of type '(value: string | null | undefined, index: number, array: (string | null | undefined)[]) => { namespace: string; onClick: (namespace: string) => void; }'.

Generated by 🚫 dangerJS against 2e8b01b

Copy link
Contributor

@andrewzamojc andrewzamojc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KATIETOLER KATIETOLER merged commit 0aea80f into main Jan 21, 2026
18 of 19 checks passed
@KATIETOLER KATIETOLER deleted the nav-update-icons-clean branch January 21, 2026 16:54
temporal-cicd bot pushed a commit that referenced this pull request Feb 4, 2026
Auto-generated version bump from 2.44.1 to 2.45.0

Bump type: minor

Changes included:
- [`4d828b96`](4d828b9) Account for potential not in conditional in custom query (#3081)
- [`bead6b37`](bead6b3) Fix truncate in detail-list-text-value (#3089)
- [`bb4bee6c`](bb4bee6) Bump svelte dependencies (#3097)
- [`586bfe19`](586bfe1) Test section
- [`4ad6cfff`](4ad6cff) Remove sisyphus and add to .gitignore (#3104)
- [`0aea80f3`](0aea80f) Nav update icons clean (#3095)
- [`bca75cc5`](bca75cc) make routes conditional on prop (#3106)
- [`0008100b`](0008100) Add new Nexus timeout fields and translations (#3105)
- [`b9939675`](b993967) Bump golang.org/x/crypto from 0.38.0 to 0.45.0 in /server (#3028)
- [`5963ca9c`](5963ca9) Nav release fix/kt (#3110)
- [`3cab346e`](3cab346) quick nav fix add logo and route to title (#3112)
- [`f9f75d64`](f9f75d6) [DT-3501] reactive timestamp (#3108)
- [`faa48e2b`](faa48e2) [DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover (#3113)
- [`068e5978`](068e597) Fix nav collapse icon (#3117)
- [`d0b34226`](d0b3422) feat(workflows): show Versioning Behavior column when filtering by deployment version (#3120)
- [`bd8a3556`](bd8a355) [DT-3580] Add tooltips to worker deployment version status badges (#3119)
- [`f46dca00`](f46dca0) Add Portal component (#3107)
- [`ef6b923e`](ef6b923) feat(deployments): make build ID and deployment name copyable and filterable (#3121)
- [`6209f9b6`](6209f9b) DT-3507-fix-code-block-scrolling (#3129)
- [`023f034b`](023f034) DT-3523 - standalone activities UI (#3124)
- [`7199ce9e`](7199ce9) Set API to v1.60.0 (#3132)
temporal-cicd bot pushed a commit that referenced this pull request Feb 4, 2026
Auto-generated version bump from 2.44.1 to 2.45.0

Bump type: minor

Changes included:
- [`4d828b96`](4d828b9) Account for potential not in conditional in custom query (#3081)
- [`bead6b37`](bead6b3) Fix truncate in detail-list-text-value (#3089)
- [`bb4bee6c`](bb4bee6) Bump svelte dependencies (#3097)
- [`586bfe19`](586bfe1) Test section
- [`4ad6cfff`](4ad6cff) Remove sisyphus and add to .gitignore (#3104)
- [`0aea80f3`](0aea80f) Nav update icons clean (#3095)
- [`bca75cc5`](bca75cc) make routes conditional on prop (#3106)
- [`0008100b`](0008100) Add new Nexus timeout fields and translations (#3105)
- [`b9939675`](b993967) Bump golang.org/x/crypto from 0.38.0 to 0.45.0 in /server (#3028)
- [`5963ca9c`](5963ca9) Nav release fix/kt (#3110)
- [`3cab346e`](3cab346) quick nav fix add logo and route to title (#3112)
- [`f9f75d64`](f9f75d6) [DT-3501] reactive timestamp (#3108)
- [`faa48e2b`](faa48e2) [DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover (#3113)
- [`068e5978`](068e597) Fix nav collapse icon (#3117)
- [`d0b34226`](d0b3422) feat(workflows): show Versioning Behavior column when filtering by deployment version (#3120)
- [`bd8a3556`](bd8a355) [DT-3580] Add tooltips to worker deployment version status badges (#3119)
- [`f46dca00`](f46dca0) Add Portal component (#3107)
- [`ef6b923e`](ef6b923) feat(deployments): make build ID and deployment name copyable and filterable (#3121)
- [`6209f9b6`](6209f9b) DT-3507-fix-code-block-scrolling (#3129)
- [`023f034b`](023f034) DT-3523 - standalone activities UI (#3124)
- [`7199ce9e`](7199ce9) Set API to v1.60.0 (#3132)
- [`138473c6`](138473c) Set API to v1.60.1 (#3134)
laurakwhit added a commit that referenced this pull request Feb 4, 2026
Auto-generated version bump from 2.44.1 to 2.45.0

Bump type: minor

Changes included:
- [`4d828b96`](4d828b9) Account for potential not in conditional in custom query (#3081)
- [`bead6b37`](bead6b3) Fix truncate in detail-list-text-value (#3089)
- [`bb4bee6c`](bb4bee6) Bump svelte dependencies (#3097)
- [`586bfe19`](586bfe1) Test section
- [`4ad6cfff`](4ad6cff) Remove sisyphus and add to .gitignore (#3104)
- [`0aea80f3`](0aea80f) Nav update icons clean (#3095)
- [`bca75cc5`](bca75cc) make routes conditional on prop (#3106)
- [`0008100b`](0008100) Add new Nexus timeout fields and translations (#3105)
- [`b9939675`](b993967) Bump golang.org/x/crypto from 0.38.0 to 0.45.0 in /server (#3028)
- [`5963ca9c`](5963ca9) Nav release fix/kt (#3110)
- [`3cab346e`](3cab346) quick nav fix add logo and route to title (#3112)
- [`f9f75d64`](f9f75d6) [DT-3501] reactive timestamp (#3108)
- [`faa48e2b`](faa48e2) [DT-3501][DT-3505] 12/24 hour and ISO formats added to timezone popover (#3113)
- [`068e5978`](068e597) Fix nav collapse icon (#3117)
- [`d0b34226`](d0b3422) feat(workflows): show Versioning Behavior column when filtering by deployment version (#3120)
- [`bd8a3556`](bd8a355) [DT-3580] Add tooltips to worker deployment version status badges (#3119)
- [`f46dca00`](f46dca0) Add Portal component (#3107)
- [`ef6b923e`](ef6b923) feat(deployments): make build ID and deployment name copyable and filterable (#3121)
- [`6209f9b6`](6209f9b) DT-3507-fix-code-block-scrolling (#3129)
- [`023f034b`](023f034) DT-3523 - standalone activities UI (#3124)
- [`7199ce9e`](7199ce9) Set API to v1.60.0 (#3132)
- [`138473c6`](138473c) Set API to v1.60.1 (#3134)

Co-authored-by: laurakwhit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants