Skip to content

Add overflow css to Codemirror extension for Firefox scrolling issue#2929

Merged
Alex-Tideman merged 1 commit into
mainfrom
firefox-mouse-issue
Sep 29, 2025
Merged

Add overflow css to Codemirror extension for Firefox scrolling issue#2929
Alex-Tideman merged 1 commit into
mainfrom
firefox-mouse-issue

Conversation

@Alex-Tideman

Copy link
Copy Markdown
Collaborator

Description & motivation 💭

Users with mouse scrolling in Firefox could not scroll the CodeBlock. This adds additional css to support scrolling.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@Alex-Tideman
Alex-Tideman requested a review from a team as a code owner September 26, 2025 19:57
@Alex-Tideman
Alex-Tideman requested review from GiantRobots and removed request for a team September 26, 2025 19:57
@vercel

vercel Bot commented Sep 26, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
holocene Ready Ready Preview Comment Sep 26, 2025 7:57pm

@Alex-Tideman
Alex-Tideman merged commit e72ca8a into main Sep 29, 2025
14 checks passed
@Alex-Tideman
Alex-Tideman deleted the firefox-mouse-issue branch September 29, 2025 13:42
temporal-cicd Bot pushed a commit that referenced this pull request Oct 8, 2025
Auto-generated version bump from 2.40.1 to 2.41.0

Bump type: minor

Changes included:
- [`904ca347`](904ca34) fix(workflows): add GitHub App token to version bump PR creation (#2910)
- [`bd50889e`](bd50889) fix(workflows): fix changelog generation and PR body formatting in version bump (#2912)
- [`ce91ecf6`](ce91ecf) style: fix formatting in version-bump workflow (#2914)
- [`352e9f66`](352e9f6) ci(workflows): add path filter to trigger-downstream-updates (#2916)
- [`9e39fa81`](9e39fa8) Add test sentence in README.
- [`68f75a20`](68f75a2) Remove test sentence
- [`73c83894`](73c8389) Start Delay UI improvements (#2907)
- [`f7924cd0`](f7924cd) Fix issue with localActivity decoding with Java sdk (#2921)
- [`474091aa`](474091a) add switch icon (#2895)
- [`a6ec2611`](a6ec261) remove monaco in favor of codemirror (#2920)
- [`b0042390`](b004239) Add quotes around allowOrigins (#2923)
- [`b809fb51`](b809fb5) feat(holocene): add VerticalNav component (#2924)
- [`e72ca8ac`](e72ca8a) Try adding overflow css to codemirror (#2929)
- [`9c472385`](9c47238) add change event to dark mode in top nav (#2930)
- [`bb750c9c`](bb750c9) fix(security): remediate command injection vulnerabilities in GitHub Actions (#2932)
- [`e54f3dc9`](e54f3dc) Add try catch around decodeForSvelte on bad params (#2934)
- [`cfc4998c`](cfc4998) replace v5 with crypto.randomuuid (#2927)
- [`a47970e9`](a47970e) Fix NaN in Batch Operations results (#2938)
- [`6cb24dec`](6cb24de) Migrate layout files to Svelte 5 (#2937)
- [`f424f03d`](f424f03) Bump tar-fs from 3.0.9 to 3.1.1 (#2926)
- [`3255f31d`](3255f31) Saved Workflow Query Views (#2931)
Alex-Tideman added a commit that referenced this pull request Oct 8, 2025
Auto-generated version bump from 2.40.1 to 2.41.0

Bump type: minor

Changes included:
- [`904ca347`](904ca34) fix(workflows): add GitHub App token to version bump PR creation (#2910)
- [`bd50889e`](bd50889) fix(workflows): fix changelog generation and PR body formatting in version bump (#2912)
- [`ce91ecf6`](ce91ecf) style: fix formatting in version-bump workflow (#2914)
- [`352e9f66`](352e9f6) ci(workflows): add path filter to trigger-downstream-updates (#2916)
- [`9e39fa81`](9e39fa8) Add test sentence in README.
- [`68f75a20`](68f75a2) Remove test sentence
- [`73c83894`](73c8389) Start Delay UI improvements (#2907)
- [`f7924cd0`](f7924cd) Fix issue with localActivity decoding with Java sdk (#2921)
- [`474091aa`](474091a) add switch icon (#2895)
- [`a6ec2611`](a6ec261) remove monaco in favor of codemirror (#2920)
- [`b0042390`](b004239) Add quotes around allowOrigins (#2923)
- [`b809fb51`](b809fb5) feat(holocene): add VerticalNav component (#2924)
- [`e72ca8ac`](e72ca8a) Try adding overflow css to codemirror (#2929)
- [`9c472385`](9c47238) add change event to dark mode in top nav (#2930)
- [`bb750c9c`](bb750c9) fix(security): remediate command injection vulnerabilities in GitHub Actions (#2932)
- [`e54f3dc9`](e54f3dc) Add try catch around decodeForSvelte on bad params (#2934)
- [`cfc4998c`](cfc4998) replace v5 with crypto.randomuuid (#2927)
- [`a47970e9`](a47970e) Fix NaN in Batch Operations results (#2938)
- [`6cb24dec`](6cb24de) Migrate layout files to Svelte 5 (#2937)
- [`f424f03d`](f424f03) Bump tar-fs from 3.0.9 to 3.1.1 (#2926)
- [`3255f31d`](3255f31) Saved Workflow Query Views (#2931)

Co-authored-by: Alex-Tideman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants