Skip to content

fix(workflows): fix changelog generation and PR body formatting in version bump#2912

Merged
rossnelson merged 3 commits into
mainfrom
fix-version-bump-changelog
Sep 15, 2025
Merged

fix(workflows): fix changelog generation and PR body formatting in version bump#2912
rossnelson merged 3 commits into
mainfrom
fix-version-bump-changelog

Conversation

@rossnelson

Copy link
Copy Markdown
Collaborator

Summary

  • Fix changelog generation in the analyze-version-bump-type action
  • Fix PR body formatting to properly display line breaks

Problem

The version bump workflow had two issues:

  1. Changelog was not being passed correctly from the analyze action due to a broken heredoc pattern
  2. PR body was showing literal \n instead of actual line breaks

Solution

  • Simplified the heredoc pattern in analyze-version-bump-type to directly output the changelog
  • Removed the broken env variable reference ${{ env.CHANGELOG_CONTENT }} that doesn't work inside bash scripts
  • Fixed PR body formatting to use proper line breaks instead of inline format strings

Test Plan

  • Run version bump workflow in auto mode
  • Verify changelog is properly generated and displayed
  • Verify PR body has proper formatting with line breaks
  • Test with manual mode to ensure fallback message works

Related Issues

…rsion bump

- Fix heredoc pattern in analyze-version-bump-type action to properly output multiline changelog
- Remove broken env variable reference that was causing changelog to not be passed
- Fix PR body formatting to properly display line breaks instead of literal \n
- Simplify conditional formatting in PR body for better readability
@rossnelson
rossnelson requested a review from a team as a code owner September 15, 2025 18:17
@rossnelson
rossnelson requested review from GiantRobots and removed request for a team September 15, 2025 18:17
@vercel

vercel Bot commented Sep 15, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
holocene Ready Ready Preview Comment Sep 15, 2025 7:33pm

- Replace local analyze-version-bump-type with analyze-commits-for-bump@v1
- Replace local calculate-version-bump with calculate-semantic-version@v1
- Use generate-changelog@v1 for commit changelog generation
- Remove unused local actions
- Always show changelog regardless of mode (auto/manual/dry-run)
- Fix PR body formatting to properly display line breaks
- Add commit links to changelog entries
@rossnelson
rossnelson merged commit bd50889 into main Sep 15, 2025
14 of 15 checks passed
@rossnelson
rossnelson deleted the fix-version-bump-changelog branch September 15, 2025 19:36
temporal-cicd Bot pushed a commit that referenced this pull request Sep 15, 2025
Auto-generated version bump from 2.40.1 to 2.41.0

Bump type: minor

Changes included:
- [`904ca347`](904ca34) fix(workflows): add GitHub App token to version bump PR creation (#2910)
- [`bd50889e`](bd50889) fix(workflows): fix changelog generation and PR body formatting in version bump (#2912)
temporal-cicd Bot pushed a commit that referenced this pull request Oct 8, 2025
Auto-generated version bump from 2.40.1 to 2.41.0

Bump type: minor

Changes included:
- [`904ca347`](904ca34) fix(workflows): add GitHub App token to version bump PR creation (#2910)
- [`bd50889e`](bd50889) fix(workflows): fix changelog generation and PR body formatting in version bump (#2912)
- [`ce91ecf6`](ce91ecf) style: fix formatting in version-bump workflow (#2914)
- [`352e9f66`](352e9f6) ci(workflows): add path filter to trigger-downstream-updates (#2916)
- [`9e39fa81`](9e39fa8) Add test sentence in README.
- [`68f75a20`](68f75a2) Remove test sentence
- [`73c83894`](73c8389) Start Delay UI improvements (#2907)
- [`f7924cd0`](f7924cd) Fix issue with localActivity decoding with Java sdk (#2921)
- [`474091aa`](474091a) add switch icon (#2895)
- [`a6ec2611`](a6ec261) remove monaco in favor of codemirror (#2920)
- [`b0042390`](b004239) Add quotes around allowOrigins (#2923)
- [`b809fb51`](b809fb5) feat(holocene): add VerticalNav component (#2924)
- [`e72ca8ac`](e72ca8a) Try adding overflow css to codemirror (#2929)
- [`9c472385`](9c47238) add change event to dark mode in top nav (#2930)
- [`bb750c9c`](bb750c9) fix(security): remediate command injection vulnerabilities in GitHub Actions (#2932)
- [`e54f3dc9`](e54f3dc) Add try catch around decodeForSvelte on bad params (#2934)
- [`cfc4998c`](cfc4998) replace v5 with crypto.randomuuid (#2927)
- [`a47970e9`](a47970e) Fix NaN in Batch Operations results (#2938)
- [`6cb24dec`](6cb24de) Migrate layout files to Svelte 5 (#2937)
- [`f424f03d`](f424f03) Bump tar-fs from 3.0.9 to 3.1.1 (#2926)
- [`3255f31d`](3255f31) Saved Workflow Query Views (#2931)
Alex-Tideman added a commit that referenced this pull request Oct 8, 2025
Auto-generated version bump from 2.40.1 to 2.41.0

Bump type: minor

Changes included:
- [`904ca347`](904ca34) fix(workflows): add GitHub App token to version bump PR creation (#2910)
- [`bd50889e`](bd50889) fix(workflows): fix changelog generation and PR body formatting in version bump (#2912)
- [`ce91ecf6`](ce91ecf) style: fix formatting in version-bump workflow (#2914)
- [`352e9f66`](352e9f6) ci(workflows): add path filter to trigger-downstream-updates (#2916)
- [`9e39fa81`](9e39fa8) Add test sentence in README.
- [`68f75a20`](68f75a2) Remove test sentence
- [`73c83894`](73c8389) Start Delay UI improvements (#2907)
- [`f7924cd0`](f7924cd) Fix issue with localActivity decoding with Java sdk (#2921)
- [`474091aa`](474091a) add switch icon (#2895)
- [`a6ec2611`](a6ec261) remove monaco in favor of codemirror (#2920)
- [`b0042390`](b004239) Add quotes around allowOrigins (#2923)
- [`b809fb51`](b809fb5) feat(holocene): add VerticalNav component (#2924)
- [`e72ca8ac`](e72ca8a) Try adding overflow css to codemirror (#2929)
- [`9c472385`](9c47238) add change event to dark mode in top nav (#2930)
- [`bb750c9c`](bb750c9) fix(security): remediate command injection vulnerabilities in GitHub Actions (#2932)
- [`e54f3dc9`](e54f3dc) Add try catch around decodeForSvelte on bad params (#2934)
- [`cfc4998c`](cfc4998) replace v5 with crypto.randomuuid (#2927)
- [`a47970e9`](a47970e) Fix NaN in Batch Operations results (#2938)
- [`6cb24dec`](6cb24de) Migrate layout files to Svelte 5 (#2937)
- [`f424f03d`](f424f03) Bump tar-fs from 3.0.9 to 3.1.1 (#2926)
- [`3255f31d`](3255f31) Saved Workflow Query Views (#2931)

Co-authored-by: Alex-Tideman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant