Skip to content

Generate camelCase types of API instead of snake case#27

Merged
stevekinney merged 1 commit into
mainfrom
ts-proto
Jul 29, 2021
Merged

Generate camelCase types of API instead of snake case#27
stevekinney merged 1 commit into
mainfrom
ts-proto

Conversation

@feedmeapples

@feedmeapples feedmeapples commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

What was changed

Switched to ts-node plugin for typescript types generation as:

  • generates camelCase
  • has great documentation (unlike protoc-gen-ts)
  • has good support for customization of output

image

Why?

To match types casing with the API server (both camelCase)

Checklist

  1. Closes

  2. How was this tested:

ran locally

  1. Any docs updates needed?

no

@stevekinney
stevekinney merged commit 879d4b1 into main Jul 29, 2021
@stevekinney
stevekinney deleted the ts-proto branch July 29, 2021 13:18
Alex-Tideman added a commit that referenced this pull request Apr 2, 2026
Implement Tier 1 detections from existing data (#9, #11, #13, #15, #19,
#23, #35) and Tier 2 detections from event history scanning (#8, #12,
#26, #27, #28, #29, #30). Adds detectEventHistoryErrors with single-pass
scanning and updates getApplicableCommonErrors to accept optional event
history. All 35 error definitions now have active detection logic.
Alex-Tideman added a commit that referenced this pull request Apr 28, 2026
* Add common-error component with 35 workflow configuration warnings (#3262)

Create a reusable common-error component system for displaying operational
guidance about workflow misconfigurations. Includes typed data for 35 known
issues with severity levels, documentation links, and a /common-errors route.

* Integrate common-error detection into workflow detail header

Add automatic detection of 21 workflow configuration issues and display
them as warnings in the workflow header. Detection covers timeout
misconfigurations, retry policy issues, heartbeat settings, and more.
Also fixes raw code references in error titles.

* Fix detection accuracy for common errors

- Raise #31 threshold from 4000 to 10000 to match "significant additional events"
- Add null guards to all getCommonErrorById calls via addError helper
- Detect #3 (short timeout) from workflowRunTimeout on first event, not just execution timeout
- Fix #10 false positives for empty retry policy objects
- Handle protobuf nanos field in durationToSeconds for sub-second durations

* Add detection logic for 14 remaining common errors (#8-#35)

Implement Tier 1 detections from existing data (#9, #11, #13, #15, #19,
#23, #35) and Tier 2 detections from event history scanning (#8, #12,
#26, #27, #28, #29, #30). Adds detectEventHistoryErrors with single-pass
scanning and updates getApplicableCommonErrors to accept optional event
history. All 35 error definitions now have active detection logic.

* Add snippet to pass in headerSnippet for common errors. Refactor workflow-run-layout to svelte5

* Add back common errors page

* Remove common errors from snippet

* Revert alert to current styles

* Fix test failures for detectFirstEventErrors and routeForCommonErrors

Update detectFirstEventErrors test calls to match updated function
signature that removed the workflow parameter. Add missing
routeForCommonErrors test case to route-for-base-path tests.

* Replace VerticalNav with tab group on common errors page

Switch from VerticalNav sidebar to TabButtons for severity filtering.
Remove layout reset (@) since the page no longer needs a custom layout.
Add WorkflowCommonErrors snippet to workflow run layout.

* Remove common errors from header snippet

* Fix type errors in alert component and stories

Rename $$Props to Props in alert.svelte for Svelte 5 convention.
Update stories to use module script and ComponentProps for proper
type inference with Storybook.

* Update src/lib/components/common-errors/common-error.svelte

Co-authored-by: Laura Whitaker <[email protected]>

* Update src/lib/components/common-errors/common-errors-data.ts

Co-authored-by: Laura Whitaker <[email protected]>

* Update src/lib/utilities/common-error-detection.ts

Co-authored-by: Laura Whitaker <[email protected]>

* Remove workflow-common-errors.svelte

* Remove getCommonErrorsByCategory

* Update src/lib/components/common-errors/common-error-list.svelte

Co-authored-by: Laura Whitaker <[email protected]>

* Fix naming

* Add back workflow-common-errors.svelte
;5u

* Formatting

* Add type predicate filter

---------

Co-authored-by: Laura Whitaker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants