Add child workflows to history compact view#228
Merged
Conversation
stevekinney
approved these changes
Jan 13, 2022
| return event.eventType === 'ActivityTaskScheduled'; | ||
| }; | ||
|
|
||
| const isChildWorkflowInitializedEvent = ( |
Contributor
There was a problem hiding this comment.
This can happen later, but you can see a world where we break these out into their own file because we might want to use them elsewhere.
| this.get(scheduledEventId).set(event.eventType, event); | ||
| } | ||
|
|
||
| if (event.eventType === 'ChildWorkflowExecutionStarted') { |
Contributor
There was a problem hiding this comment.
Eventually we're going to need to go back and address the test coverage. I think that we should ship the functionality for now, but we'll need to pay down the technical debt over the next few weeks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added child workflows to history compact view
Why?
helpful at understanding history of large workflows
Checklist
Closes
How was this tested: