Add better path matching for active links#11
Merged
Merged
Conversation
feedmeapples
approved these changes
Jul 14, 2021
| @@ -0,0 +1,13 @@ | |||
| export const pathMatches = (first: string, second: string): boolean => { | |||
Contributor
There was a problem hiding this comment.
should we also clear out query strings?
hferentschik
pushed a commit
to hferentschik/temporal-ui
that referenced
this pull request
Aug 13, 2025
Revert "[WFENG-2551] go straight to vault for SSO (temporalio#5)"
hferentschik
pushed a commit
to hferentschik/temporal-ui
that referenced
this pull request
Aug 13, 2025
* Revert "Merge pull request temporalio#11 from DataDog/revert-5-bg/skip-click" This reverts commit ca8fda6, reversing changes made to 8fce4c8. * use local storage * use ttl for state * don't minify * use current location for state redirect * move redirect to layout root * don't minify anymore * feedback skip instead of comment tests and clarify comments
Alex-Tideman
added a commit
that referenced
this pull request
Apr 2, 2026
Implement Tier 1 detections from existing data (#9, #11, #13, #15, #19, #23, #35) and Tier 2 detections from event history scanning (#8, #12, #26, #27, #28, #29, #30). Adds detectEventHistoryErrors with single-pass scanning and updates getApplicableCommonErrors to accept optional event history. All 35 error definitions now have active detection logic.
Alex-Tideman
added a commit
that referenced
this pull request
Apr 28, 2026
* Add common-error component with 35 workflow configuration warnings (#3262) Create a reusable common-error component system for displaying operational guidance about workflow misconfigurations. Includes typed data for 35 known issues with severity levels, documentation links, and a /common-errors route. * Integrate common-error detection into workflow detail header Add automatic detection of 21 workflow configuration issues and display them as warnings in the workflow header. Detection covers timeout misconfigurations, retry policy issues, heartbeat settings, and more. Also fixes raw code references in error titles. * Fix detection accuracy for common errors - Raise #31 threshold from 4000 to 10000 to match "significant additional events" - Add null guards to all getCommonErrorById calls via addError helper - Detect #3 (short timeout) from workflowRunTimeout on first event, not just execution timeout - Fix #10 false positives for empty retry policy objects - Handle protobuf nanos field in durationToSeconds for sub-second durations * Add detection logic for 14 remaining common errors (#8-#35) Implement Tier 1 detections from existing data (#9, #11, #13, #15, #19, #23, #35) and Tier 2 detections from event history scanning (#8, #12, #26, #27, #28, #29, #30). Adds detectEventHistoryErrors with single-pass scanning and updates getApplicableCommonErrors to accept optional event history. All 35 error definitions now have active detection logic. * Add snippet to pass in headerSnippet for common errors. Refactor workflow-run-layout to svelte5 * Add back common errors page * Remove common errors from snippet * Revert alert to current styles * Fix test failures for detectFirstEventErrors and routeForCommonErrors Update detectFirstEventErrors test calls to match updated function signature that removed the workflow parameter. Add missing routeForCommonErrors test case to route-for-base-path tests. * Replace VerticalNav with tab group on common errors page Switch from VerticalNav sidebar to TabButtons for severity filtering. Remove layout reset (@) since the page no longer needs a custom layout. Add WorkflowCommonErrors snippet to workflow run layout. * Remove common errors from header snippet * Fix type errors in alert component and stories Rename $$Props to Props in alert.svelte for Svelte 5 convention. Update stories to use module script and ComponentProps for proper type inference with Storybook. * Update src/lib/components/common-errors/common-error.svelte Co-authored-by: Laura Whitaker <[email protected]> * Update src/lib/components/common-errors/common-errors-data.ts Co-authored-by: Laura Whitaker <[email protected]> * Update src/lib/utilities/common-error-detection.ts Co-authored-by: Laura Whitaker <[email protected]> * Remove workflow-common-errors.svelte * Remove getCommonErrorsByCategory * Update src/lib/components/common-errors/common-error-list.svelte Co-authored-by: Laura Whitaker <[email protected]> * Fix naming * Add back workflow-common-errors.svelte ;5u * Formatting * Add type predicate filter --------- Co-authored-by: Laura Whitaker <[email protected]>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds a
pathMatchesutility function for theNavigationLinkcomponent that works when the current path is a subdirectory—for lack of a better word—of theNavigationLink.Why?
Previous to this change, the Workflows icon would no longer be highlighted if you navigated from
/workflowsto/workflows/:workflow_id/:run_idor some variation on that that. This addresses that.