Remove pinned dependency for modernc.org/sqlite#8489
Merged
prathyushpv merged 5 commits intomainfrom Oct 16, 2025
Merged
Conversation
yiminc
approved these changes
Oct 15, 2025
yiminc
approved these changes
Oct 15, 2025
chaptersix
pushed a commit
to temporalio/cli
that referenced
this pull request
Dec 17, 2025
## What was changed Wiring in new enableReplication flag into cluster upsert cli. Deleting sql pinning test as we no longer need this, see historical context: #784 temporalio/temporal#7333 then unpinning in OSS temporalio/temporal#8489 ## Why? Allows for users to leverage the new field ## Checklist 1. Closes 2. How was this tested: built locally and tested in conjunction with temporalio/temporal#8744, used the cli manually to make a replication based test pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Remove pinned dependency on modernc.org/sqlite.
Why?
We added this version override when we experienced some table not found errors. This happens when sqlite db connections are closed when transactions fail.
We have TestSQLiteTransactionContextCancellation which passes consistently for this new version. So we believe this issue should not happen again.
How did you test it?