Merged
Conversation
stephanos
commented
Sep 3, 2025
| pm.rateLimitManager.Stop() | ||
| pm.versionedQueuesLock.Lock() | ||
| defer pm.versionedQueuesLock.Unlock() | ||
| pm.rateLimitManager.Stop() |
carlydf
approved these changes
Sep 3, 2025
Contributor
carlydf
left a comment
carlydf
left a comment
There was a problem hiding this comment.
Approved! Really nice job pinning this down 🙏
Nit: Could you change the title / add something to the title to indicate "revert but moved pm.rateLimitManager.Stop() after pm.versionedQueuesLock.Lock()" or "revert but with fix"
stephanos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8263 which reverted #8135
So this is #8135 plus a fix for flaky tests.
Comparing the results of the test runs (4 each) for the original (1st commit) and fix (2nd commit), I can only conclude that the issue has been addressed.