Skip to content

Comments

Revert "TaskQueue Fairness Rate Limit (#8135)"#8263

Merged
spkane31 merged 2 commits intomainfrom
spk/revert-8135
Aug 29, 2025
Merged

Revert "TaskQueue Fairness Rate Limit (#8135)"#8263
spkane31 merged 2 commits intomainfrom
spk/revert-8135

Conversation

@spkane31
Copy link
Contributor

What changed?

Revert the changes in #8135

Why?

Tests have been flaky since this PR merged.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

Unknown changes to task queue rate limiting

@spkane31 spkane31 requested a review from a team as a code owner August 29, 2025 22:58
@spkane31 spkane31 enabled auto-merge (squash) August 29, 2025 23:23
@spkane31 spkane31 merged commit cf8e774 into main Aug 29, 2025
58 checks passed
@spkane31 spkane31 deleted the spk/revert-8135 branch August 29, 2025 23:46
stephanos added a commit that referenced this pull request Sep 2, 2025
@temporal-cicd temporal-cicd bot mentioned this pull request Sep 2, 2025
kepe-temporal pushed a commit that referenced this pull request Sep 2, 2025
Patch release 1.29.0 with PR(s):
- [#8263](#8263)

---------

Co-authored-by: Sean Kane <[email protected]>
Co-authored-by: temporal-cicd[bot] <temporal-cicd[bot]@users.noreply.github.com>
stephanos added a commit that referenced this pull request Sep 3, 2025
Reverts #8263 which reverted
#8135

So this is #8135 plus a fix
for flaky tests.

Comparing the results of the test runs (4 each) for the original (1st
commit) and fix (2nd commit), I can only conclude that the issue has
been addressed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants