Merged
Conversation
2 tasks
alexshtin
reviewed
May 14, 2025
| } | ||
|
|
||
| // HistoryBootstrapContainer contains components needed by all history Archiver implementations | ||
| HistoryBootstrapContainer struct { |
Contributor
Author
There was a problem hiding this comment.
Did you add these? Was that before fx?
alexshtin
reviewed
May 14, 2025
|
|
||
| testBase.Setup(clusterMetadataConfig) | ||
| archiverBase := newArchiverBase(clusterConfig.EnableArchival, logger) | ||
| archiverBase := newArchiverBase(clusterConfig.EnableArchival, testBase.ExecutionManager, logger) |
Contributor
There was a problem hiding this comment.
I have plans around this archiverBase too.
alexshtin
approved these changes
May 14, 2025
Contributor
alexshtin
left a comment
alexshtin
left a comment
There was a problem hiding this comment.
Build is failing. Otherwise great step in the right direction.
dnr
force-pushed
the
david/refactor-archival-fx
branch
from
92c8be0 to
6b82b9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Refactor how archival subsystem gets its dependencies to work better with fx:
Why?
The service type maps were causing issues like #7631, and are unnecessary.
How did you test it?