Make deployment APIs work with possible version_id in the future#7218
Merged
carlydf merged 3 commits intoss/update-deployment-wf-idsfrom Feb 2, 2025
Merged
Make deployment APIs work with possible version_id in the future#7218carlydf merged 3 commits intoss/update-deployment-wf-idsfrom
carlydf merged 3 commits intoss/update-deployment-wf-idsfrom
Conversation
carlydf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Made deployment workflow ids based on the version id (deploymeny name / build id).
Standardized internal variable naming so that
version stringalways refers to the fully-qualified version identifier, whereasbuild_id stringalways refers to build id.Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?