Merged
Conversation
carlydf
reviewed
Jan 30, 2025
Contributor
carlydf
left a comment
carlydf
left a comment
There was a problem hiding this comment.
really close! just left a few comments
| // tell new ramping version it's ramping | ||
| rampUpdateArgs := &deploymentspb.SyncVersionStateUpdateArgs{ | ||
| RoutingUpdateTime: updateTime, | ||
| RampingSinceTime: updateTime, |
Contributor
There was a problem hiding this comment.
RampingSinceTime is a bit weird, because if the ramp % is changing but the ramping version is staying the same, RampingSinceTime will not change, because the time when the version started ramping is still the same.
I would make a variable called newRampingSinceTime and do:
newRampingSinceTime = updateTime // if this version is newly ramping
if prevRampingVersion == newRampingVersion { // this version was already ramping
newRampingSinceTime = d.State.RoutingInfo.RampingVersionUpdateTime
}
| // update local state | ||
| d.State.RoutingInfo.RampingVersion = newRampingVersion | ||
| d.State.RoutingInfo.RampingVersionPercentage = args.Percentage | ||
| d.State.RoutingInfo.RampingVersionUpdateTime = updateTime |
Contributor
There was a problem hiding this comment.
If the RampingVersion stayed the same, d.State.RoutingInfo.RampingVersionUpdateTime should not change
Contributor
There was a problem hiding this comment.
possibly update d.State.RoutingInfo.RampingVersionPercentageUpdateTime
Member
Author
There was a problem hiding this comment.
In my latest commit, d.State.RoutingInfo.RampingVersionUpdateTime now works correctly - I have not made the addition to percentage yet due to a opinion I had which I pasted on our slack thread
carlydf
reviewed
Jan 30, 2025
| if d.State.RoutingInfo.CurrentVersion == d.State.RoutingInfo.RampingVersion { | ||
| d.State.RoutingInfo.RampingVersion = "" | ||
| d.State.RoutingInfo.RampingVersionPercentage = 0 | ||
| d.State.RoutingInfo.RampingVersionUpdateTime = nil |
Contributor
There was a problem hiding this comment.
this should be updateTime not nil
tests/worker_deployment_test.go
Outdated
| RoutingInfo: &deploymentpb.RoutingInfo{ | ||
| RampingVersion: "", // no ramping info should be set | ||
| RampingVersionPercentage: 0, // no ramping info should be set | ||
| RampingVersionUpdateTime: nil, // no ramping info should be set |
Contributor
There was a problem hiding this comment.
this should be the same as CurrentVersionUpdateTime, not nil
| RegisterWorkerInDeployment = "register-task-queue-worker" // for Worker Deployment Version wf | ||
| SyncVersionState = "sync-version-state" // for Worker Deployment Version wfs | ||
| SetCurrentVersion = "set-current-version" // for Worker Deployment wfs | ||
| SetRampingVersion = "set-worker-deployment-ramping-version" // for Worker Deployment wfs |
Contributor
There was a problem hiding this comment.
Nit: maybe make the string be "set-ramping-version" to match "set-current-version" above
| if prevRampingVersion == newRampingVersion { // the version was alread ramping, user changing ramp % | ||
| rampingSinceTime = d.State.RoutingInfo.RampingVersionUpdateTime | ||
| } else { | ||
| rampingSinceTime = timestamppb.New(workflow.Now(ctx)) // version ramping for the first time |
Contributor
There was a problem hiding this comment.
Suggested change
| rampingSinceTime = timestamppb.New(workflow.Now(ctx)) // version ramping for the first time | |
| rampingSinceTime = routingUpdateTime // version ramping for the first time |
carlydf
approved these changes
Jan 30, 2025
ShahabT
pushed a commit
that referenced
this pull request
Feb 4, 2025
## What changed? <!-- Describe what has changed in this PR --> - Ramping PR for versioning-3.1 - now, if a ramping version becomes current, the ramp will be unset. ## Why? <!-- Tell your future self why have you made these changes --> - Versioning-3.1 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> - Added more functional tests - Existing suite ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> - None, going to feature. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No
ShahabT
pushed a commit
that referenced
this pull request
Feb 5, 2025
## What changed? <!-- Describe what has changed in this PR --> - Ramping PR for versioning-3.1 - now, if a ramping version becomes current, the ramp will be unset. ## Why? <!-- Tell your future self why have you made these changes --> - Versioning-3.1 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> - Added more functional tests - Existing suite ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> - None, going to feature. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No
ShahabT
pushed a commit
that referenced
this pull request
Feb 5, 2025
## What changed? <!-- Describe what has changed in this PR --> - Ramping PR for versioning-3.1 - now, if a ramping version becomes current, the ramp will be unset. ## Why? <!-- Tell your future self why have you made these changes --> - Versioning-3.1 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> - Added more functional tests - Existing suite ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> - None, going to feature. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No
ShahabT
pushed a commit
that referenced
this pull request
Feb 6, 2025
## What changed? <!-- Describe what has changed in this PR --> - Ramping PR for versioning-3.1 - now, if a ramping version becomes current, the ramp will be unset. ## Why? <!-- Tell your future self why have you made these changes --> - Versioning-3.1 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> - Added more functional tests - Existing suite ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> - None, going to feature. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No
ShahabT
pushed a commit
that referenced
this pull request
Feb 6, 2025
## What changed? <!-- Describe what has changed in this PR --> - Ramping PR for versioning-3.1 - now, if a ramping version becomes current, the ramp will be unset. ## Why? <!-- Tell your future self why have you made these changes --> - Versioning-3.1 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> - Added more functional tests - Existing suite ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> - None, going to feature. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No
ShahabT
pushed a commit
that referenced
this pull request
Feb 6, 2025
## What changed? <!-- Describe what has changed in this PR --> - Ramping PR for versioning-3.1 - now, if a ramping version becomes current, the ramp will be unset. ## Why? <!-- Tell your future self why have you made these changes --> - Versioning-3.1 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> - Added more functional tests - Existing suite ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> - None, going to feature. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No
ShahabT
pushed a commit
that referenced
this pull request
Feb 6, 2025
## What changed? <!-- Describe what has changed in this PR --> - Ramping PR for versioning-3.1 - now, if a ramping version becomes current, the ramp will be unset. ## Why? <!-- Tell your future self why have you made these changes --> - Versioning-3.1 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> - Added more functional tests - Existing suite ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> - None, going to feature. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?
No