Use latest modernc.org/sqlite and remove temporary fix#6836
Merged
prathyushpv merged 1 commit intomainfrom Nov 18, 2024
Merged
Conversation
stephanos
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Use the latest release of modernc.org/sqlite library which has our fix for the connection cancellation issue: https://gitlab.com/cznic/sqlite/-/merge_requests/74.
We had a temporary fix merged in #6815. Reverting that as well.
Why?
Sqlite library did not implement functions ResetSession() and IsValid() in the database connection. sql library was discarding a database connection when a context was canceled during a transaction. The new version of modernc.org/sqlite has these two methods implemented.
How did you test it?
Existing unit test to verify the connection is not lost.
Potential risks
None
Documentation
Is hotfix candidate?
No