Conversation
Member
chris-olszewski
left a comment
chris-olszewski
left a comment
There was a problem hiding this comment.
Mostly questions. Not sure I have enough context to approve
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
| ConfigDataSource, | ||
| } from './types'; | ||
|
|
||
| export { fromTomlConfig, fromTomlProfile, toTomlConfig, toTomlProfile, loadConfigData } from './utils'; |
Contributor
There was a problem hiding this comment.
Do we really want to expose all of those functions publicly? If so, we'll also need to expose the Toml* types.
But I'd preach to avoid conflating the public API surface at this point.
Contributor
Author
There was a problem hiding this comment.
Yes. We have followed a pattern across SDKs to allow users to convert to/from TOML representations on their own.
Contributor
There was a problem hiding this comment.
In that case, we'll need to also export the Toml* interfaces and remove the @internal annotation on those.
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 20, 2025
mjameswh
reviewed
Oct 23, 2025
mjameswh
reviewed
Oct 23, 2025
mjameswh
reviewed
Oct 23, 2025
mjameswh
reviewed
Oct 23, 2025
mjameswh
reviewed
Oct 23, 2025
mjameswh
reviewed
Oct 23, 2025
mjameswh
reviewed
Oct 23, 2025
mjameswh
reviewed
Oct 23, 2025
mjameswh
reviewed
Oct 23, 2025
mjameswh
reviewed
Oct 23, 2025
mjameswh
reviewed
Oct 23, 2025
mjameswh
reviewed
Oct 23, 2025
mjameswh
approved these changes
Oct 23, 2025
Contributor
mjameswh
left a comment
mjameswh
left a comment
There was a problem hiding this comment.
A few more details; see comments. But ok to merge once you've handled those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Created
envconfigpackage, functionality that allows users to configureConnectionorNativeConnectionbacked clients (or just the connection itself for that matter).Why?
Allows users to configure connections/clients from config files instead of source code.
Closes [Feature Request] Environment Configuration #1727
How was this tested:
Integration test suite at
test-envconfig.tsAny docs updates needed?
Yes