Add meters to custom slot supplier contexts#913
Merged
Sushisource merged 3 commits intomasterfrom May 13, 2025
Merged
Conversation
cretz
approved these changes
May 13, 2025
Contributor
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Looks to not affect any languages (most use telemetry().get_metric_meter() as needed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add metrics meters to slot supplier contexts & fix bug where attach metrics was useless on a tuner holder
Why?
Fixes bug & allows for recording metrics on slot supplier contexts.
Mostly used this as a testpiece for some agentic AI coding.
Checklist
Closes [Bug] TunerHolder's attach_metrics is useless #904
How was this tested:
Added test
Any docs updates needed?