Evictions in their own activations#712
Merged
Sushisource merged 4 commits intotemporalio:masterfrom Mar 29, 2024
Merged
Conversation
cretz
approved these changes
Mar 29, 2024
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
I don't understand the details, but if no tests fail and we don't expect this to have any outside effect on users, this LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Evictions now always come in their own activation
Why?
Simpler contract for lang
Checklist
Closes
How was this tested:
Existing tests
Any docs updates needed?