External environment configuration sample#420
Merged
yuandrew merged 6 commits intotemporalio:mainfrom Aug 27, 2025
Merged
Conversation
THardy98
approved these changes
Jul 31, 2025
Contributor
THardy98
left a comment
THardy98
left a comment
There was a problem hiding this comment.
LGTM, just a nit basically.
Wonder if it would be better to split the samples out into their own files, but it doesn't look like that's typical in this repo
|
|
||
| return opts | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe worth leaving a comment here explaining what the default config is if you provide no config
cretz
reviewed
Aug 4, 2025
Member
There was a problem hiding this comment.
This does not close #390. The issue there is to update every sample to using external environment configuration instead of assuming localhost default so every sample can use environment configuration. I'm not even sure we really need an environment configuration sample, but I have no problem with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added example using external environment configuration
Why?
new feature!
Checklist
Closes
How was this tested:
Ran locally, some methods don't "work" out of the box, but demonstrate how users would use this new feature
Any docs updates needed?