Conversation
stephanos
force-pushed
the
move-gen-cmds
branch
2 times, most recently
from
20dfb62 to
799bff4
Compare
stephanos
force-pushed
the
move-gen-cmds
branch
from
799bff4 to
6e5b88d
Compare
cretz
approved these changes
Dec 12, 2025
Member
There was a problem hiding this comment.
FWIW, I think it's not the best that these internal tools are alongside the primary binary as an equal and would have liked to see us entertain an option of making these just undocumented commands inside the existing binary, but not a strong objection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Moved
internal/cmd/gen-commandstocmd/gen-commands; and same forgen-docs.Why?
When they are in
internal/they cannot be invoked viago runfrom outside the repository; making it cumbersome to use.Checklist
Closes
How was this tested: