Wire enableReplication into cli#881
Conversation
|
|
<!-- Describe what has changed in this PR --> **What changed?** Enable reading of new field added in AddOrUpdateRemoteClusterResponse as these apparently aren't sharing/reusing a common proto for reading/writing <!-- Tell your future self why have you made these changes --> **Why?** Enabling reads from cli <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** na <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** temporalio/temporal#8744 cli PR - temporalio/cli#881
<!-- Describe what has changed in this PR --> **What changed?** Enable reading of new field added in AddOrUpdateRemoteClusterResponse as these apparently aren't sharing/reusing a common proto for reading/writing <!-- Tell your future self why have you made these changes --> **Why?** Enabling reads from cli <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** na <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** temporalio/temporal#8744 cli PR - temporalio/cli#881
5dc43f4 to
dbd24ee
Compare
|
Semgrep found 3
No explicit |
cretz
left a comment
There was a problem hiding this comment.
LGTM since it targets next-server, but will let someone on the CLI team provide approval
## What changed? Wiring in #8658 but for operator api ## Why? Compatibility with CLI ## How did you test it? - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) in our functional test I commented out ``` // Enable replication active -> standby _, err = activeCluster.AdminClient().AddOrUpdateRemoteCluster( ctx, &adminservice.AddOrUpdateRemoteClusterRequest{ FrontendAddress: standbyCluster.Host().RemoteFrontendGRPCAddress(), FrontendHttpAddress: standbyCluster.Host().FrontendHTTPAddress(), EnableRemoteClusterConnection: true, EnableReplication: true, // NOW enable replication }) s.Require().NoError(err) // Enable replication standby -> active _, err = standbyCluster.AdminClient().AddOrUpdateRemoteCluster( ctx, &adminservice.AddOrUpdateRemoteClusterRequest{ FrontendAddress: activeCluster.Host().RemoteFrontendGRPCAddress(), FrontendHttpAddress: activeCluster.Host().FrontendHTTPAddress(), EnableRemoteClusterConnection: true, EnableReplication: true, // NOW enable replication }) s.Require().NoError(err) ``` and used a locally built cli temporalio/cli#881 to enable, test passed
## What changed? Wiring in temporalio#8658 but for operator api ## Why? Compatibility with CLI ## How did you test it? - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) in our functional test I commented out ``` // Enable replication active -> standby _, err = activeCluster.AdminClient().AddOrUpdateRemoteCluster( ctx, &adminservice.AddOrUpdateRemoteClusterRequest{ FrontendAddress: standbyCluster.Host().RemoteFrontendGRPCAddress(), FrontendHttpAddress: standbyCluster.Host().FrontendHTTPAddress(), EnableRemoteClusterConnection: true, EnableReplication: true, // NOW enable replication }) s.Require().NoError(err) // Enable replication standby -> active _, err = standbyCluster.AdminClient().AddOrUpdateRemoteCluster( ctx, &adminservice.AddOrUpdateRemoteClusterRequest{ FrontendAddress: activeCluster.Host().RemoteFrontendGRPCAddress(), FrontendHttpAddress: activeCluster.Host().FrontendHTTPAddress(), EnableRemoteClusterConnection: true, EnableReplication: true, // NOW enable replication }) s.Require().NoError(err) ``` and used a locally built cli temporalio/cli#881 to enable, test passed
…ith latest versions)
chaptersix
left a comment
There was a problem hiding this comment.
We should probably document when to use the next-server branch instead of main.
## What changed? Wiring in #8658 but for operator api ## Why? Compatibility with CLI ## How did you test it? - [x] built - [x] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) in our functional test I commented out ``` // Enable replication active -> standby _, err = activeCluster.AdminClient().AddOrUpdateRemoteCluster( ctx, &adminservice.AddOrUpdateRemoteClusterRequest{ FrontendAddress: standbyCluster.Host().RemoteFrontendGRPCAddress(), FrontendHttpAddress: standbyCluster.Host().FrontendHTTPAddress(), EnableRemoteClusterConnection: true, EnableReplication: true, // NOW enable replication }) s.Require().NoError(err) // Enable replication standby -> active _, err = standbyCluster.AdminClient().AddOrUpdateRemoteCluster( ctx, &adminservice.AddOrUpdateRemoteClusterRequest{ FrontendAddress: activeCluster.Host().RemoteFrontendGRPCAddress(), FrontendHttpAddress: activeCluster.Host().FrontendHTTPAddress(), EnableRemoteClusterConnection: true, EnableReplication: true, // NOW enable replication }) s.Require().NoError(err) ``` and used a locally built cli temporalio/cli#881 to enable, test passed
- Remove sqlite version pinning test (matches next-server PR temporalio#881) - Add sleep for version registration in reset tests (matches next-server PR temporalio#908)
Add --enable-replication flag to the cluster upsert command and display IsReplicationEnabled in cluster list output. Cherry-picked from #881 (next-server branch). Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add --enable-replication flag to the cluster upsert command and display IsReplicationEnabled in cluster list output. Cherry-picked from #881 (next-server branch). https://github.com/temporalio/cli/pull/881/changes Co-authored-by: Claude Opus 4.5 <[email protected]>
What was changed
Wiring in new enableReplication flag into cluster upsert cli.
Deleting sql pinning test as we no longer need this, see historical context:
#784
temporalio/temporal#7333
then unpinning in OSS temporalio/temporal#8489
Why?
Allows for users to leverage the new field
Checklist
Closes
How was this tested:
built locally and tested in conjunction with temporalio/temporal#8744, used the cli manually to make a replication based test pass