Add temporal worker deployment manager-identity commands#858
Conversation
| ) | ||
| assert.NoError(t, res.Err) | ||
| assert.Contains(t, res.Stdout.String(), deploymentName) | ||
| }, 30*time.Second, 100*time.Millisecond) |
There was a problem hiding this comment.
Can this test really take 30s or is this just a common value we're using everywhere?
EDIT: I saw in downloaded junit files that this test takes 1.2s. That's not too bad. Tests TestDeployment_Describe_Drainage and TestDeployment_List take over 2s, tests TestDeployment_Ramping and TestDeployment_Set_Current_Version take over 5s, and test TestWorkflow_Batch_Update_Options_Versioning_Override takes over 10s (the slowest test in the repo). May want to open an issue to look into improving those, but not blocking this PR.
There was a problem hiding this comment.
Glad you pointed this out! I just copied that timeout from the tests Antonio wrote, didn't base it on a specific time expectation. Things may have taken longer in the initial pre-release because we weren't doing the task queue user data in batches, which we now are.
3 participants
What was changed
Add
temporal worker deployment manager-identitycommands (setandunset)Why?
So that CLI clients of Worker Deployments that are managed by an automated system (such as the Kubernetes Worker Controller) can safely coordinate with that client to make intended changes and ensure they are not overwritten.
Checklist
Closes
How was this tested:
Added a new test. Also tested in SDK and server.
Any docs updates needed?