Skip to content

Routing Information to be present in describe WorkerDeployment calls#527

Merged
Shivs11 merged 4 commits intoversioning-3.1from
ss/routing_in_WorkerDeployment
Jan 24, 2025
Merged

Routing Information to be present in describe WorkerDeployment calls#527
Shivs11 merged 4 commits intoversioning-3.1from
ss/routing_in_WorkerDeployment

Conversation

@Shivs11
Copy link
Copy Markdown
Member

@Shivs11 Shivs11 commented Jan 23, 2025

READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.

What changed?

  • Pretty much the title

Why?

  • versioning-3.1

Breaking changes

Server PR

  • developing

@Shivs11 Shivs11 requested review from a team and carlydf January 24, 2025 16:33
@Shivs11 Shivs11 merged commit 1d5811f into versioning-3.1 Jan 24, 2025
@Shivs11 Shivs11 deleted the ss/routing_in_WorkerDeployment branch January 24, 2025 16:33
@antlai-temporal
Copy link
Copy Markdown
Contributor

@ShahabT and @Shivs11 We were discussing on using __unversioned__ instead of just "" for ramping_version (and possibly current_version), to make it more explicit what we are trying to do. Are we settle on this? Is there another PR coming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants