Fix CMake deprecation warning for old CMake versions#2821
Merged
oy merged 3 commits intoteeworlds:masterfrom Dec 13, 2020
Merged
Fix CMake deprecation warning for old CMake versions#2821oy merged 3 commits intoteeworlds:masterfrom
oy merged 3 commits intoteeworlds:masterfrom
Conversation
Declare that we're fine with policies up to 3.19.1. This should fix policy errors and "too low cmake_minimal_version() errors" for the forseeable future. (cherry picked from commit 59cbc01)
Contributor
Author
Seems like I also need to get rid of that. Will do that later™. |
Contributor
Author
|
Hm, the commit was seemingly unnecessary, as we already set the Reverts #2264. |
Fixes #3355. Works around google/googletest#3040. (cherry picked from commit 037b928)
This reverts commit 2958b80.
heinrich5991
force-pushed
the
pr_cmake_version_werror
branch
from
7b3ee24 to
cd506ff
Compare
Contributor
Author
|
Ah, seems like we can't use newer GTest versions because we don't use C++11. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from ddnet/ddnet#3387.
Works around google/googletest#3040.