Allow custom boot/connect timeouts for testcloud VMs#2677
Merged
Conversation
happz
requested review from
frantisekz,
janhavlin,
lukaszachy,
psss and
thrix
as code owners
1 task
Contributor
Author
|
/packit test |
lukaszachy
force-pushed
the
testcloud-control-boot-connect-timeouts
branch
from
1d1e900 to
9f2e070
Compare
Contributor
Author
|
/packit test |
happz
force-pushed
the
testcloud-control-boot-connect-timeouts
branch
from
9f2e070 to
dd43fba
Compare
Contributor
|
Shouldn't we add |
Contributor
Author
Added in ebed80d |
lukaszachy
approved these changes
Feb 12, 2024
frantisekz
approved these changes
Feb 12, 2024
Contributor
Author
|
/packit test |
1 similar comment
Contributor
Author
|
/packit test |
Contributor
Author
|
I'm looking for inputs from @frantisekz, the failure of parallel test stinks with race conditions :/ |
psss
requested changes
Feb 14, 2024
Member
psss
left a comment
psss
left a comment
There was a problem hiding this comment.
Looks good, just two suggestions.
happz
force-pushed
the
testcloud-control-boot-connect-timeouts
branch
from
01b9a8a to
00b8b8d
Compare
psss
added
step | provision
psss
force-pushed
the
testcloud-control-boot-connect-timeouts
branch
from
297b643 to
846e2a7
Compare
Member
Yeah, looks like that. Filed #2687 to track this. Everything else passed, let's not block the PR on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist