-
Notifications
You must be signed in to change notification settings - Fork 166
TMT_TREE vs TMT_SOURCE_DIR #2184
Copy link
Copy link
Open
Labels
area | environmentEnvironment variables handlingEnvironment variables handlingdocumentationImprovements or additions to documentationImprovements or additions to documentationstatus | blockedThe merging of PR is blocked on some other issueThe merging of PR is blocked on some other issue
Description
I was examining this run and I've noticed something peculiar in how the design works. In my test I have:
rlRun "rsync -r $TMT_TREE$TMT_TEST_NAME/ $tmp" 0 "Copy example project"
But that does not work in upstream because it should point to TMT_SOURCE_DIR.
But then, what's the usecase of having TMT_TREE not point to TMT_SOURCE_DIR when using a plan with
discover:
how: fmf
dist-git-source: trueIf we consider other cases when using how: fmf with url or otherwise, in those cases the source is available at TMT_TREE right? Only dist-git behaves differently with the downloaded tree pointing to a different location.
Is there a reason for having these be different? Should the behaviour be how non-dist-git download work, or the other way around? A temporary fix is possible with ${TMT_SOURCE_DIR:-$TMT_TREE}, but it is unexpected to have to do that.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area | environmentEnvironment variables handlingEnvironment variables handlingdocumentationImprovements or additions to documentationImprovements or additions to documentationstatus | blockedThe merging of PR is blocked on some other issueThe merging of PR is blocked on some other issue