feat!: remove config object cloning to fix TokenCredential issues

BrandonNoad · dhensby · commit 5fcc7d702342 · 2025-09-30T12:09:15.000+01:00
BREAKING CHANGE: Config objects are not longer cloned by the library.
The objects are intended to be readonly and that no modification happens
to them during the lifetime of the process, changing these values will result
in undefined behaviour.
diff --git a/lib/base/connection-pool.js b/lib/base/connection-pool.js
@@ -7,7 +7,6 @@ const tarn = require('tarn')
 const { IDS } = require('../utils')
 const ConnectionError = require('../error/connection-error')
 const shared = require('../shared')
-const clone = require('rfdc/default')
 const { MSSQLError } = require('../error')
 
 /**
@@ -53,7 +52,7 @@ class ConnectionPool extends EventEmitter {
         throw ex
       }
     } else {
-      this.config = clone(config)
+      this.config = config
     }
 
     // set defaults
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -37,7 +37,6 @@
     "@tediousjs/connection-string": "^0.6.0",
     "commander": "^11.0.0",
     "debug": "^4.3.3",
-    "rfdc": "^1.3.0",
     "tarn": "^3.0.2",
     "tedious": "^19.0.0"
   },
diff --git a/test/common/unit.js b/test/common/unit.js
@@ -343,17 +343,6 @@ describe('Geography Parsing', () => {
   })
 })
 
-describe('config cloning', () => {
-  it('deeply clones configs', () => {
-    const options = {}
-    const pool = new BasePool({
-      server: 'Instance\\Name',
-      options
-    })
-    assert.notDeepStrictEqual(options, pool.config.options)
-  })
-})
-
 describe('value handlers', () => {
   afterEach('reset valueHandler', () => {
     sql.valueHandler.clear()

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,6 @@ const tarn = require('tarn')`
`7`	`7`	`const { IDS } = require('../utils')`
`8`	`8`	`const ConnectionError = require('../error/connection-error')`
`9`	`9`	`const shared = require('../shared')`
`10`		`-const clone = require('rfdc/default')`
`11`	`10`	`const { MSSQLError } = require('../error')`
`12`	`11`
`13`	`12`	`/**`
`@@ -53,7 +52,7 @@ class ConnectionPool extends EventEmitter {`
`53`	`52`	`throw ex`
`54`	`53`	`}`
`55`	`54`	`} else {`
`56`		`- this.config = clone(config)`
	`55`	`+ this.config = config`
`57`	`56`	`}`
`58`	`57`
`59`	`58`	`// set defaults`