Conversation
|
Hey @JuanPabloDiaz ! Love the love you're giving to that team page!
😱 @cgrail that's a huge number of contributions!
What's your node version? How are you starting the project? |
Co-authored-by: Nima Izadi <[email protected]>
Co-authored-by: Nima Izadi <[email protected]>
Co-authored-by: Nima Izadi <[email protected]>
Node.js v20.11.0
npm start |
|
@JuanPabloDiaz I pushed some small types to remove some errors and my editor auto linted. Hmm, I'm not sure why you're getting your errors. 🤔 I do have a question though: how do you plan to bypass the GitHub rate limitation? Maybe we could have a static file we can generate once in a while? Or piggy back on if GitHub returns a 429? |
That's a good point! I didn't really consider that as an issue in production. While refreshing during development is normal, typical users wouldn't be reloading that frequently. The static file will be a good idea in case we get a 429. |
|
That's fair. Whether a static JSON list or even just a message explaining why it's not loading. Or even just not showing the section at all. Whatever you prefer, I don't have a strong opinion here. I've merged a bunch of dependabot PRs, so you will have to rebase and |
|
Locally, I'm surprised you get the errors. The errors that are on CI are just prettier. You should be able to get rid of them by running prettier locally. |
Looking at the changes, things look good. Rebases can definitely be tricky some times. I often find myself just recreating a new PR and porting my commits one by one or something alike. |
Co-authored-by: Nima Izadi <[email protected]>
Co-authored-by: Nima Izadi <[email protected]>
Co-authored-by: Nima Izadi <[email protected]>
Co-authored-by: Nima Izadi <[email protected]>
Co-authored-by: Nima Izadi <[email protected]>
Co-authored-by: Nima Izadi <[email protected]>
Co-authored-by: Nima Izadi <[email protected]>
Co-authored-by: Nima Izadi <[email protected]>
Co-authored-by: Nima Izadi <[email protected]>
|
Is there anything else that I need or could do? |
|
Sorry for the delay @JuanPabloDiaz, I didn't have the change to test that page again locally. Could you make the build pass? Looks like you have type error at: TOPICS[x].toLocaleLowerCase(), |
I am not sure what that means. But hey, now I have another error. 57 conflicts in |
|
I fixed some of the build errors and package.json conflicts. Time to 🚢 ! Thank you for the great work 🙏🏼 |


Here is a first version of the Team page. I add to the project:
Maintainer sectionto the team pageContributors sectionto the team page. Fetching data from:SCSSfile that match the colors and style from the website.Datafolder to store maineners data and dummyData for the contributors during the dev.Here is how it should look:
Please let me know what you think!
Additional information
I am getting a bunch of error when running the project locally and I am not sure how to fix it. Please advise.