Skip to content

Team Page#632

Merged
nimzco merged 52 commits intotech-conferences:mainfrom
JuanPabloDiaz:team
Jul 3, 2024
Merged

Team Page#632
nimzco merged 52 commits intotech-conferences:mainfrom
JuanPabloDiaz:team

Conversation

@JuanPabloDiaz
Copy link
Contributor

@JuanPabloDiaz JuanPabloDiaz commented Jun 14, 2024

Here is a first version of the Team page. I add to the project:

  • Maintainer section to the team page
  • Contributors section to the team page. Fetching data from:
    • Confs.tech contributors
    • Conference Data contributors
  • SCSS file that match the colors and style from the website.
  • Data folder to store maineners data and dummyData for the contributors during the dev.

Here is how it should look:

image
Please let me know what you think!

Additional information

I am getting a bunch of error when running the project locally and I am not sure how to fix it. Please advise.

image

@JuanPabloDiaz JuanPabloDiaz changed the title Team Page (not ready) Team Page Jun 16, 2024
@nimzco
Copy link
Member

nimzco commented Jun 18, 2024

Hey @JuanPabloDiaz ! Love the love you're giving to that team page!
Generally speaking, I liked the low key team page, but at the same time, it might help us having more contributors in the future :)

image

😱 @cgrail that's a huge number of contributions!

I am getting a bunch of error when running the project locally and I am not sure how to fix it. Please advise.

What's your node version? How are you starting the project?

@JuanPabloDiaz
Copy link
Contributor Author

JuanPabloDiaz commented Jun 18, 2024

5438 contribution 😱 @cgrail that's a huge number of contribution!

Yeah, that is a huge number @cgrail. Congrats for the hard work!

@JuanPabloDiaz
Copy link
Contributor Author

I am getting a bunch of error when running the project locally and I am not sure how to fix it. Please advise.

What's your node version?

Node.js v20.11.0

How are you starting the project?

npm start

@nimzco
Copy link
Member

nimzco commented Jun 18, 2024

@JuanPabloDiaz I pushed some small types to remove some errors and my editor auto linted.

Hmm, I'm not sure why you're getting your errors. 🤔
I'm using node v19.8.1 and npm 9.5.1.

I do have a question though: how do you plan to bypass the GitHub rate limitation? Maybe we could have a static file we can generate once in a while? Or piggy back on if GitHub returns a 429?

@JuanPabloDiaz
Copy link
Contributor Author

JuanPabloDiaz commented Jun 18, 2024

I do have a question though: how do you plan to bypass the GitHub rate limitation? Maybe we could have a static file we can generate once in a while? Or piggy back on if GitHub returns a 429?

That's a good point! I didn't really consider that as an issue in production. While refreshing during development is normal, typical users wouldn't be reloading that frequently.

The static file will be a good idea in case we get a 429.

@nimzco
Copy link
Member

nimzco commented Jun 19, 2024

That's fair. Whether a static JSON list or even just a message explaining why it's not loading. Or even just not showing the section at all. Whatever you prefer, I don't have a strong opinion here.

I've merged a bunch of dependabot PRs, so you will have to rebase and npm install again.

@JuanPabloDiaz
Copy link
Contributor Author

JuanPabloDiaz commented Jun 19, 2024

The build command is still throwing me a bunch of errors regarding import issues.

The way I fix it was by update the tsconfig.json file:

  "include": ["src**"]

I am wondering if that is okey? The errors are gone on my end. 😃

image

@nimzco
Copy link
Member

nimzco commented Jun 19, 2024

Locally, I'm surprised you get the errors. The errors that are on CI are just prettier. You should be able to get rid of them by running prettier locally.
I tried running npm run lint -- --fix but it didn't fix the issues 🤔

@nimzco
Copy link
Member

nimzco commented Jun 19, 2024

With that being said. I failed rebasing last night, so I dropped it this morning and tried again. After I rebase and fill ALL the conflicts, I merge team and my main branch. is that a problem?

Looking at the changes, things look good. Rebases can definitely be tricky some times. I often find myself just recreating a new PR and porting my commits one by one or something alike.

@JuanPabloDiaz
Copy link
Contributor Author

Is there anything else that I need or could do?

@nimzco
Copy link
Member

nimzco commented Jul 2, 2024

Sorry for the delay @JuanPabloDiaz, I didn't have the change to test that page again locally.
I'll try to do that tonight.

Could you make the build pass? Looks like you have type error at:

TOPICS[x].toLocaleLowerCase(),

@JuanPabloDiaz
Copy link
Contributor Author

Could you make the build pass? Looks like you have type error at:

TOPICS[x].toLocaleLowerCase(),

I am not sure what that means.

But hey, now I have another error. 57 conflicts in package-lock.json. LOL 😮

@nimzco
Copy link
Member

nimzco commented Jul 3, 2024

I fixed some of the build errors and package.json conflicts.

Time to 🚢 !

Thank you for the great work 🙏🏼

@nimzco nimzco merged commit 7b732c7 into tech-conferences:main Jul 3, 2024
@JuanPabloDiaz JuanPabloDiaz deleted the team branch July 3, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants