Tebex 694 - Add defaultPaymentMethod option, expose CheckoutZoidProps type#23
Merged
Chilledson merged 3 commits intoMay 2, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new defaultPaymentMethod option to the checkout process and exposes the CheckoutZoidProps type as part of the public API.
- Adds tests for the default-payment-method attribute on the web component and for the checkout initialization behavior
- Updates type definitions and exports in both tests and source files to support the new defaultPaymentMethod option
- Enhances the checkout's option resolution by adding a dedicated resolver for defaultPaymentMethod
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/webComponents/TebexCheckout.test.ts | Adds a test to verify that the default-payment-method attribute sets the checkout.defaultPaymentMethod correctly. |
| tests/index.test-d.ts | Extends type tests to include CheckoutZoidProps and other new type exports. |
| tests/checkout.test.ts | Introduces tests for setting a valid defaultPaymentMethod and validating improper values with warning behavior. |
| src/webComponents/TebexCheckout.ts | Passes the default-payment-method attribute value to the checkout initialization. |
| src/index.ts | Exports the new type definitions for the checkout API including CheckoutZoidProps. |
| src/checkout.ts | Adds defaultPaymentMethod to the CheckoutOptions type, initializes it in the Checkout class, and implements a resolver method. |
Files not reviewed (1)
- package.json: Language not supported
Chilledson
approved these changes
May 2, 2025
Contributor
|
This feature has now been enabled, documentation to follow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.