8139322383 Fix Nuxt support#20
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (2)
rollup.config.js:64
- [nitpick] Consider specifying explicit delimiters to narrowly match the intended code snippets, which helps avoid accidental replacements if the surrounding context changes.
delimiters: ["", ""]
rollup.config.js:61
- Verify that the new variable name 'zoidGlobal' is consistently used throughout the codebase to prevent mismatches.
"var global = global_getGlobal();": "var zoidGlobal = global_getGlobal();",
Chilledson
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nuxt tries to change instances of
globaltoglobalThis, however it's a little overzealous, and ends up breaking Zoid / post-robot since it replaces a local variable namedglobalinside thegetWildcardfunction.This would cause the error
Unhandled Promise Rejection: Error: WeakMap expected keyto be thrown when trying to launch the tebex.js popup.This particular line in Nuxt is the culprit:
https://github.com/nuxt/nuxt/blob/a69751b96d35b0b2a4d7674652c604e45370f60c/packages/vite/src/vite.ts#L243
Which was causing this line in post-robot to be incorrectly replaced with
globalThis.WINDOW_WILDCARD:https://github.com/krakenjs/post-robot/blob/30ab862e90a023531cd46d5fe8a7342c887b521b/src/global.js#L89
This solution uses Rollup's replace function to rename the variable so that it won't be replaced by Nuxt.