docs: README rebrand npm package zeit/ms to ms#373
Closed
MikeMcC399 wants to merge 1 commit intotcort:masterfrom
Closed
docs: README rebrand npm package zeit/ms to ms#373MikeMcC399 wants to merge 1 commit intotcort:masterfrom
MikeMcC399 wants to merge 1 commit intotcort:masterfrom
Conversation
Contributor
Author
|
This fix should also be applied to https://github.com/tcort/link-check |
Contributor
Author
|
Withdrawn, since there has been no response. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The README document refers in several places to the npm package
zeit/ms.ZEIT is now Vercel describes that a rebranding took place in April 2020.
The GitHub repo link https://github.com/zeit/ms redirects to https://github.com/vercel/ms
The npm repo reports not found for https://www.npmjs.com/package/zeit/ms, whereas https://www.npmjs.com/package/ms links to the current Vercel repo https://github.com/vercel/ms.
Change
Change reference to the npm package
zeit/msto ms.This is a documentation-only change. The hyperlink targets were already using the up-to-date location https://www.npmjs.com/package/ms.