Updates plrust/build to programmatically get pgrx version #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradyBonnette
commented
Sep 7, 2023
plrust/build
Outdated
| --version "0.10.0" \ | ||
| --locked # use the Cargo.lock in the pgrx repo | ||
| # Attempt to get pgrx version from cargo tree. Looking for a pattern such as "pgrx v0.10.0" | ||
| PGRX_VERSION=$(cargo tree | grep -E "\s*pgrx\s+v[0-9]+\.[0-9]+\.[0-9]+" | head -n 1 | cut -f2- -dv) |
Contributor
Author
There was a problem hiding this comment.
Just realized that this should maybe be cargo tree --package plrust. Thoughts?
Contributor
There was a problem hiding this comment.
yeah, probably. I think the thing I send you on Discord assumed being in the plrust/ crate directory. Testing manually it doesn't seem to matter tho.
Could also add --depth 1
eeeebbbbrrrr
approved these changes
Sep 8, 2023
Contributor
eeeebbbbrrrr
left a comment
eeeebbbbrrrr
left a comment
There was a problem hiding this comment.
My comment aside, I think this is fine. If you're done done done, feel free to merge it.
plrust/build
Outdated
| --version "0.10.0" \ | ||
| --locked # use the Cargo.lock in the pgrx repo | ||
| # Attempt to get pgrx version from cargo tree. Looking for a pattern such as "pgrx v0.10.0" | ||
| PGRX_VERSION=$(cargo tree | grep -E "\s*pgrx\s+v[0-9]+\.[0-9]+\.[0-9]+" | head -n 1 | cut -f2- -dv) |
Contributor
There was a problem hiding this comment.
yeah, probably. I think the thing I send you on Discord assumed being in the plrust/ crate directory. Testing manually it doesn't seem to matter tho.
Could also add --depth 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #377
When plrust goes through a release cycle, occasionally (read: pretty much "almost" every time) we forget to update the hard-coded pgrx version in the
plrust/buildscript due to the fact that our automated release tooling does not consider nor modify the script file. With the changes in this PR, we programmatically get the pgrx version usingcargo treeand some unix utils magic so that nobody has to think about updating that value ever again upon release.