Fixes MacOS nightly; Introduces nightly mdbook build #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeeebbbbrrrr
approved these changes
Sep 7, 2023
Contributor
eeeebbbbrrrr
left a comment
eeeebbbbrrrr
left a comment
There was a problem hiding this comment.
I guess this is fine. I'll merge now and we'll see what CI does with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly MacOS test runs were failing due to the updated integration test structure recently introduced to the project. Part of these changes addresses that situation.
The other part of the changes introduces an mdbook nightly build. This does not publish the documentation, it only checks to make sure that mdbook+plugins can install and build the documentation properly. I believe it was necessary because the only time documentation is built is when a release happens, and if documentation generation fails for whatever reason, we find out only after a release has been published. The hope is that this should catch any errors before we release.
NOTE: This PR wants to be merged into tcdi/plrust:main directly, as it is only CI changes and the nightly updates can be applied immediately instead of waiting for another plrust release.