Skip to content

Use typeck_results.node_type to resolve the type in suspicious trait object lint #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomcc merged 2 commits into from
Jul 6, 2023
Merged

Use typeck_results.node_type to resolve the type in suspicious trait object lint #349

thomcc merged 2 commits into from
Jul 6, 2023

Conversation

@thomcc
Copy link
Contributor

@thomcc thomcc commented Jul 6, 2023

Thanks to @compiler-errors for helping me out here, this is much cleaner too.

Fixes #348 (we still may want to turn lints entirely off when compiling dependencies, but fixing it for real is better, and trying to parse a bunch of things out of the rustc args felt hairy without a bit more testing).

@thomcc
Copy link
Contributor Author

thomcc commented Jul 6, 2023

Note that without the change, the example I added would hit a similar ICE to the rand one. I can't add a dep on rand to the compiletests, and I don't think the plrust test suite supports deps in trusted mode, so this is probably the best option.

@thomcc thomcc requested a review from workingjubilee July 6, 2023 17:05
@eeeebbbbrrrr
Copy link
Contributor

eeeebbbbrrrr commented Jul 6, 2023 •
edited
Loading

I don't think the plrust test suite supports deps in trusted mode

It does. The test suite actually sets up an allow-list so it can test that. Would be no problem to add rand to it and use rand in a unit test.

see

plrust/plrust/src/tests.rs

Lines 1401 to 1411 in 07bec8d

let mut allowed_deps = std::fs::File::create(&file_path).unwrap();
allowed_deps
.write_all(
r#"
owo-colors = "=3.5.0"
tokio = { version = "=1.19.2", features = ["rt", "net"]}
plutonium = "*"
"#
.as_bytes(),
)
.unwrap();

@thomcc
Copy link
Contributor Author

thomcc commented Jul 6, 2023

It does. The test suite actually sets up an allow-list so it can test that. Would be no problem to add rand to it and use rand in a unit test.

Ah, I confused the sandbox feature (no network) with trusted. (I thought somehow it had been renamed and I hadn't noticed).

I've added the test.

eeeebbbbrrrr
eeeebbbbrrrr approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the unit test!

@thomcc thomcc merged commit 46705ba into main Jul 6, 2023
@thomcc thomcc deleted the thomcc/no-associated-ice branch July 6, 2023 18:06
thomcc added a commit that referenced this pull request Jul 6, 2023
@thomcc
Revert "Use typeck_results.node_type to resolve the type in suspici…
95d7a0c 
…ous trait object lint (#349)"

This reverts commit 46705ba.
@thomcc thomcc mentioned this pull request Jul 6, 2023
Merged
@thomcc thomcc restored the thomcc/no-associated-ice branch July 6, 2023 20:08
thomcc added a commit that referenced this pull request Jul 6, 2023
@thomcc
Use typeck_results.node_type to resolve the type in suspicious trai…
f9cb8d0 
…t object lint (#349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@workingjubilee workingjubilee Awaiting requested review from workingjubilee

1 more reviewer

@eeeebbbbrrrr eeeebbbbrrrr eeeebbbbrrrr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

plrustc panics during compilation when using the rand crate

3 participants

@thomcc @eeeebbbbrrrr