[immutable-arraybuffer] ArrayBuffer.prototype.sliceToImmutable#4553
Merged
gibson042 merged 1 commit intoMay 7, 2026
Merged
Conversation
67 tasks
gibson042
force-pushed
the
2025-07-immutable-arraybuffer-slicetoimmutable
branch
from
August 1, 2025 01:30
51629c7 to
f9ed2c1
Compare
ptomato
approved these changes
Aug 25, 2025
ptomato
left a comment
Contributor
There was a problem hiding this comment.
Minor comments, feel free to merge when resolved
| ---*/ | ||
|
|
||
| var fn = ArrayBuffer.prototype.sliceToImmutable; | ||
| assert.sameValue(typeof fn, "function", "Method must exist."); |
Contributor
There was a problem hiding this comment.
Suggested change
| assert.sameValue(typeof fn, "function", "Method must exist."); |
I think this is sufficiently implied by the immutable-arraybuffer feature flag.
| ---*/ | ||
|
|
||
| var fn = ArrayBuffer.prototype.sliceToImmutable; | ||
| assert.sameValue(typeof fn, "function", "Method must exist."); |
| ---*/ | ||
|
|
||
| var fn = ArrayBuffer.prototype.sliceToImmutable; | ||
| assert.sameValue(typeof fn, "function", "Method must exist."); |
Contributor
There was a problem hiding this comment.
Already implied by feature flag.
Comment on lines
+124
to
+128
| "sliceToImmutable(" + repr(rawStart) + ", " + repr(rawEnd) + ")"); | ||
| assert.compareArray(new Uint8Array(dest), expectContents, | ||
| "sliceToImmutable(" + repr(rawStart) + ", " + repr(rawEnd) + ")"); | ||
| assert.sameValue(dest.immutable, true, | ||
| "sliceToImmutable(" + repr(rawStart) + ", " + repr(rawEnd) + ")"); |
Contributor
There was a problem hiding this comment.
Minor suggestion, add something to these assertion messages to distinguish which assertion is failing (byte length, contents, or immutability) (Same for below)
iamstolis
reviewed
Oct 6, 2025
iamstolis
reviewed
Oct 6, 2025
iamstolis
reviewed
Oct 6, 2025
iamstolis
reviewed
Oct 6, 2025
iamstolis
reviewed
Oct 6, 2025
gibson042
force-pushed
the
2025-07-immutable-arraybuffer-slicetoimmutable
branch
2 times, most recently
from
May 7, 2026 16:33
2444f54 to
638465c
Compare
gibson042
force-pushed
the
2025-07-immutable-arraybuffer-slicetoimmutable
branch
from
May 7, 2026 16:43
638465c to
6a9848a
Compare
ptomato
pushed a commit
that referenced
this pull request
May 11, 2026
…type.sliceToImmutable Ref #4553 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #4509