[immutable-arraybuffer] ArrayBuffer.prototype.immutable#4541
Conversation
4f01207 to
c722f14
Compare
|
@Ms2ger looks like your comment was addressed; should this now be "needs review" instead of "awaiting author"? |
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
I'd prefer not to have the isHardened thing, and I have a suggestion for avoiding it. Otherwise all looks good.
|
|
||
| assert.sameValue(desc.value, undefined); | ||
| assert.sameValue(desc.set, undefined); | ||
| verifyCallableProperty(desc, "get", "get immutable", 0, { configurable: !isHardened }); |
There was a problem hiding this comment.
I think we wanted to isolate the accommodations for hardened JS environments (i.e. nonstandard) in the harness files as much as possible. Although verifyPrimordialCallableProperty doesn't seem quite right here, as desc.get isn't primordial.
That said, do we really need to check the configurable flag of desc.get here? If it's set incorrectly that seems more like an implementation issue with Object.getOwnPropertyDescriptor that should be covered in the tests for that API. So maybe assert.sameValue(typeof desc.get, "function") would be sufficient here.
WDYT?
…cessorProperty` analog Ref tc39#4541 (comment)
177ec70 to
33559cb
Compare
...with an overridable `verifyProperty` dependency
…cessorProperty` analog Ref tc39#4541 (comment)
33559cb to
906e368
Compare
5 participants
Ref #4509