Conversation
rwaldron
requested changes
Sep 7, 2021
Contributor
rwaldron
left a comment
rwaldron
left a comment
There was a problem hiding this comment.
@anba three lint issues:
/home/circleci/test262/test/intl402/Intl/supportedValuesOf/builtin.js: FRONTMATTER - Unrecognized fields: include
/home/circleci/test262/test/intl402/Intl/supportedValuesOf/numberingSystems-with-simple-digit-mappings.js: INCLUDES - Unused include: "testIntl.js"
/home/circleci/test262/test/intl402/NumberFormat/prototype/format/numbering-systems.js: INCLUDES - Unused include: "testIntl.js"
leobalter
reviewed
Sep 7, 2021
Member
leobalter
left a comment
leobalter
left a comment
There was a problem hiding this comment.
Adding the suggestions here that might help speeding up the process to land this PR.
test/intl402/Intl/supportedValuesOf/numberingSystems-with-simple-digit-mappings.js
Show resolved
Hide resolved
…Systems, and simple sanctioned units And then use these helpers to replace hard-coded lists in other tests.
Covers the usual surface tests and additional functionality tests which were upstreamed from existing tests in SpiderMonkey. Fixes tc39#3131
Contributor
Author
rwaldron
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers the usual surface tests and additional functionality tests which were
upstreamed from existing tests in SpiderMonkey.
Fixes #3131