Remove double error tests#2290
Merged
leobalter merged 1 commit intotc39:masterfrom Aug 13, 2019
Snapstromegon:master
Merged
Conversation
Due to changing idempotenxy for dynamic import on failures these tests are no longer needed. After tc39/ecma262#1645 idempotency is only required after completing normally.
Member
|
It's unfortunate we can't really test anything else as counter tests. If I read the proposed text correctly, this behavior remains correct but not required. I'm not sure what should be done in a second call. |
leobalter
approved these changes
Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapts tests for tc39/ecma262#1645.
Due to changing idempotency for dynamic import on failures these tests are no longer needed.
After tc39/ecma262#1645 idempotency is only required after completing normally.